Commit Graph

3034 Commits

Author SHA1 Message Date
Mark Liversedge
b0dafea5c7 Compare Pane Mockup
.. balsamiq mockup and png export
2013-11-27 19:42:01 +01:00
Mark Liversedge
e526fd4f94 Add GPS/Altitude alignment to Compare spec
.. we should make it possible to display interval
   data aligned via the altitude or gps data as well
   as via time/distance. This really only applies to
   the ride plot.
2013-11-26 11:56:35 +01:00
Mark Liversedge
a8cbfc2f15 Update Compare Document
.. to reflect feedback from Damien re compare sets

.. Also changed the compare pane to be view specific and
   shared across all charts in the view.
2013-11-25 09:02:45 +00:00
Mark Liversedge
d12b3fc6ec Compare button icon 2013-11-24 14:20:42 +00:00
Mark Liversedge
4d5b8d9cba Compare toolbar/menu option
Just added a toolbar button and menu to bring up the
compare pane, before adding it to the tab and view
classes.
2013-11-24 14:18:21 +00:00
Mark Liversedge
5c1e2b3809 Plot CP model for derived power series
.. not sure of the validity of applying the model
   to derived data series like xPower and aPower
   but it may provide some insight.
2013-11-23 21:08:50 +00:00
Mark Liversedge
4efb597f26 Fix CP defaults bug
.. set to 3600 not 360 (!)

.. updated intervals causing warnings when using values
   that were half baked. Now delays recalc() till all
   the parameter intervals are set.
2013-11-22 22:30:47 +00:00
Mark Liversedge
e7e6bdf968 Better CP model defaults
Improved defaults for CP model to derive CP
and W' from bests data.
2013-11-22 21:59:29 +00:00
Mark Liversedge
61a6116fa5 Fencepost error on CP intervals
.. caused the meanmax curve for an interval to be
   recomputed every time even though we'd gone to all
   those lengths to cache them.
2013-11-21 18:28:01 +00:00
Mark Liversedge
dd8b8537b4 Date Format on Athlete Bests
.. didn't follow the same standard as the rest of
   GC, minor cosmetic fixup.
2013-11-21 17:59:50 +00:00
Mark Liversedge
34841bad1d Move uml docs to the design folder 2013-11-21 10:07:22 +00:00
Mark Liversedge
87d4b8a9aa Adding Compare design outline
Jusst jotted down thoughts about implementing compare in v3.1
and added to the documentation folder. Will try and get some
mockups sorted too in the near future.
2013-11-21 09:41:00 +00:00
Mark Liversedge
8a74223726 Fix WIN32 build issue in main.cpp
.. nostderr() not supported on Windows.
2013-11-20 14:13:26 +00:00
Mark Liversedge
d3a3a76ccc Fix stderr redirect platform issues
.. don't use toLatin1() and fopen, use QFile and full QStrings
   so we can support directory names with unicode characters.

.. add unistd.h for dup() and close()
2013-11-20 14:08:28 +00:00
Mark Liversedge
d548cccf49 Better Command Line Processing
Now accepts --debug to disable redirection of stderr to
goldencheetah.log, which is handy for developers.

Also refined the way the command line is processed to enable
new arguments to be added in the future.
2013-11-20 13:26:25 +00:00
Mark Liversedge
ad84abf291 Redirect stderr to goldencheetah.log
In the home directory of GC (platform specific or configured
by the user). This is only relevant for OpenBSD, Linux and Mac.

Windows does not support applications that are GUI and console.
2013-11-20 12:48:09 +00:00
Mark Liversedge
bea2cfb5f2 Fix CP chart defaults
The CP chart model defaults are set before the spin box step
min and max values are set, which means that the value is always
reset to 100.

Since the vast majority of users will not be aware of the settings
and/or will never think of setting them to their own 'preferences'
it is vital the default is applied correctly.
2013-11-20 08:08:55 +00:00
Damien
7dd8524e5c CP Model: let the user define whole interval durations 2013-11-20 08:17:49 +01:00
Damien
0642932aae FitRideFile: - Add Left/Right TorqueEff and Left/Rigth PedalSmooth
- Open Truncated file
2013-11-19 22:38:18 +01:00
gcoco
274d3f9580 Add Garmin Forerunner 910XT 2013-11-18 14:27:47 -05:00
Mark Liversedge
9fe5e0c04a Slight cosmetic on new Athlete bests
.. and don't show zero values.
2013-11-16 22:44:43 +00:00
Mark Liversedge
5d77d14b43 Athlete Bests on Summary
Configurable metrics to show top 10 bests for date
range selected.
2013-11-16 21:01:01 +00:00
Mark Liversedge
173f6a10f8 Fix show W' on AllPlot bug
.. redraw didn't happen until you changed smoothing
   or selected a ride file.
2013-11-16 13:39:02 +00:00
Mark Liversedge
a1efef850b Command line parsing
Now allows:

$ GoldenCheetah [[directory] athlete]
$ GoldenCheetah [--version|--help]
$ GoldenCheetah

Passing the athlete on its own is as before, but you can
now also pass the folder name in as well.

I've also added the option to get a help message if you
pass --version or --help.

Lastly, as before, with no command line paramaters you
open the last athlete worked on.

Since we now output the version and build info I have uplifted
the build and version numbers in GcUpgrade.h to reflect the fact
we are now developing v3.1.
2013-11-16 11:14:44 +00:00
Mark Liversedge
7f66a870bd Restart properly when home changes
After fixing up the trainDB problem we can now restart
the mainwindows safely when the athlete directory changes.
2013-11-16 09:38:17 +00:00
Mark Liversedge
e2f4ab73e3 Training DB clean up gracefully
When closing down we left the training database open
and this caused problems when looking to implement
a restart function.

The problems stemmed from the way the QSqlDatabase
code was implemented in TrainDB which was modelled on
code in DBAccess that was cleaned up subsequently.

TrainDB code now mirrors the approach taken in DBAccess
and relinquishes resources correctly. The TrainDB is now
closed as well as being opened in main.cpp at startup.

Also, removed reference to obsolete dbconn member in the
DBAccess class definition since it is no longer used.
2013-11-16 08:33:11 +00:00
Mark Liversedge
3d3657e79b User definable athlete library location
Allow the user to select a directory to use for the
athlete libary. Leaving it blank will continue to use
the default location (dependent on platform).

If it is changed the user will be asked to confirm
and then GC shuts down.

Restart wouldn't work due to issues with the DBAccess
QSqlDatabase connection (which is really annoying). I
will look into this as a restart option would be much
cleaner.

Its only taken 4 years to implement this feature! (ouch).

Fixes #282.
2013-11-15 23:19:04 +00:00
Mark Liversedge
cee2c1b138 Honour "CP" override in W'
W' calculator didn't use the "CP" metadata to override the
CP for the ride.
2013-11-15 18:14:17 +00:00
Mark Liversedge
135f3e366c Fix W' crash smoothing sub-second recording. 2013-11-14 23:02:30 +00:00
Mark Liversedge
58d0b0b9e9 Don't truncate 3 parameter CP curve 2013-11-14 17:17:06 +00:00
Mark Liversedge
d0f0904bde CP Curve tmin
.. accidentally left at 0s now corrected back
   to truncate at tau for the 2 parameter model
   and set to 25s for the 3 parameter mode where
   it seems to breakdown.
2013-11-14 16:21:50 +00:00
Mark Liversedge
9b3c9ab5d2 Estimate CP and W' in CP Estimator
Since we want to track W' and CP now it makes sense
to add W' estimation to the tool.
2013-11-14 14:11:59 +00:00
Mark Liversedge
69f502d044 The CP Model has "parameters" not "points"
Might as well use the right terminology if your gonna
let the user choose and adjust the model!
2013-11-14 12:24:37 +00:00
Mark Liversedge
48d072db4a User Definable CP Model
Let the user define whether to use a 2 point or
3 point model (Morton et al).

In addition, let the user define the interval durations
to use; by default we set to 3 and 30 mins.

For estimating CP against good, recent data both of these
models are more than adequate for the purpose.

We'll just keep kicking the can down the road whilst we
can rely on published, verified science.
2013-11-14 11:43:55 +00:00
Mark Liversedge
ff035d685c Reinstate 3 point CP model
DJ Connel implemented a 3 point model, after Morton,
which was erroneously removed in a prior commit.

Our thanks to Andy Coggan for pointing this out in a
recent webinar. Nice to know he is following us closely.
2013-11-14 09:22:06 +00:00
Mark Liversedge
a0b8c5be11 Clean CP curve
.. when in range mode (i.e. plotting a CP curve for a date
   range or season rather than for a ride).
2013-11-13 23:00:26 +00:00
Mark Liversedge
86f04b165b UI Nits: Less clunky CP curve
When no shading selected it really does no shading and
the CP model curve is now in a smaller line width.
2013-11-13 21:06:14 +00:00
Mark Liversedge
2430c73d93 Highlight intervals on CP Curve
Will show a CP curve for the selected data series
for each interval that is selected, just like the
rest of the charts.

Fixes #718.
2013-11-13 20:38:06 +00:00
Mark Liversedge
a79b490e42 UX: Add to intervals flow
.. in the find intervals dialog it makes more sense to
   close the dialog once add to activity has been pressed.
2013-11-13 10:29:28 +00:00
Mark Liversedge
a00d77bd97 LTM Speedup
.. don't refresh when not visible!

   This is a side effect of the code updates added
   to handle filtering in chart settings or the global
   search/datafilter box.
2013-11-13 08:25:23 +00:00
Mark Liversedge
44b04dae12 Clear results when switch type
.. to W' bal or Ascent type interval searching
2013-11-12 18:58:40 +00:00
Mark Liversedge
dfb5157ec8 Find Ascents
.. another method for find intervals to find the ascents
   in a ride. Uses the hysteresis as defined in options
   which means a climb ends if there is a descent of that
   or more (by default only 3m).
2013-11-12 18:09:24 +00:00
Mark Liversedge
24e12eb024 Remove References in Dialog
.. you can now choose to remove reference lines in the
   allplot when you double click on the axis.

.. we might want to put the table and buttons for deleting
   references into the chart settings too (?)
2013-11-12 13:16:44 +00:00
Mark Liversedge
613ddb916b UI Nits: Less is more
.. remove grid line from CP plot.
2013-11-12 09:19:05 +00:00
Mark Liversedge
07784615ae UI Nits: Matches markers in CWBAL color 2013-11-11 23:18:51 +00:00
Mark Liversedge
217d6ab7ad UI Nits: Matches markers lower
.. so they don't clash with other interval markers
   most especially user supplied interval marks
2013-11-11 23:11:46 +00:00
Mark Liversedge
735099ea68 UI Nits: Back to black in QA
.. the washed out grey was unpopular and is too
   hard to read.
2013-11-11 22:53:49 +00:00
Mark Liversedge
0fa3da925b UI Nits: Less Ride Plot xBottom
.. no title needed for time, its obvious, but
   still need to show units if its distance.
2013-11-11 22:26:29 +00:00
Mark Liversedge
514b726850 UI Nits: Thinner reference line
2px too thick for a guide, made 1px which is in
line with the rest of the code.
2013-11-11 22:11:38 +00:00
Mark Liversedge
00a52abff4 UI Nits: Less is more
Further removal of chart decorations ala the recent
changes to the ride plot, now applied to the other
charts.
2013-11-11 22:04:06 +00:00