- Crash on syntax error happened on <leaf> destructor and the cause
was tokens declared as <leaf> but not creating a leaf, to avoid
this a new <string> type without destructor was added for them.
- Warnings indicated semantic value not set for some rules due to
the lack of $$ = $1, likely bening, but lets avoid it.
This is a continuation of 523ffcc, %destructor bison
directive is used to clean and delete Leaf nodes
allocated and discarded by the parser.
Hopefully fixes#4249
This started to happen after #4277, problem is when parsing fails
treeRoot can point ot non Leaf objects. This does not happens when
parsing from the DataFilter constructor since treeRoot is forced
to NULL on errors, this commit does the same for check and parseFilter.
Remaining problem is the memory leak in these cases, which are frequent
when editing filters in User or LTM charts as explained in #4249
The crash documented in #4249 was related to the conversion of
Leaf of type Symbol to Function when () are found afterwards.
This is fixed in this commit, but more testing is necessary to
see if there are other cases.
clearFilter - delete root Leaf
Leaf constructor: initialize left,right and cond to null pointers
Leaf::clear avoid crashes when called with a null pointer parameter,
and release memory in all cases allocated in the parser
TODO: still crashes if called from DataFilter destructor, see #4249
Missing from RC2 build, also include the fix to avoid crashes when
myPerspective is not set in existing charts and default layouts
without R charts to avoid #4267 for newly create athletes.
[publish binaries]
This was reported at the forum and it is reproducible with
the supplied home-perspectives.xml, it was likely generated
by an older version, but lets get defensive just in case.
- DragDropMode is changed from InternalMove to DragDrop in RideTreeView,
this enables compare of activities again
- DragDropMode is changed from InternalMove to DragDrop in SeasonTreeView,
MoveAction is made the default action and dragEnterEvent ignores
events other than move or from other origins. This avoids compared
date ranges loosing their names.
- DragDropMode is changed from InternalMove to DragDrop in IntervalTreeView,
MoveAction is made the default action and dragEnterEvent ignores
events other than move or from other origins. This avoids removal
of compared intervals from the intervals list.
This solution was contributed by Joachim at the users forum.
Fixes#3622
[publish binaries]
Items are not editable, so it is not used in the normal flow,
and it worsen a bug which clears the date range name in the item
when dropping on compare pane commiting the change to seasons.xml
This allows to request all points at once since post api has
no limits according the documentation.
Break logic is preserve just in case we need it in the future.
Fixes#4261
