Speedup isMetricRelevantForRides method

Shortcut or is enough
This commit is contained in:
Alejandro Martinez
2016-10-08 09:50:26 -03:00
parent ca262a28ce
commit ddcbd287c7

View File

@@ -907,16 +907,14 @@ bool
RideCache::isMetricRelevantForRides(Specification specification,
const RideMetric* metric)
{
bool isRelevant = false;
// loop through and aggregate
foreach (RideItem *ride, rides_) {
// skip filtered rides
if (!specification.pass(ride)) continue;
isRelevant = isRelevant || metric->isRelevantForRide(ride);
if (metric->isRelevantForRide(ride)) return true;
}
return isRelevant;
return false;
}