From ddcbd287c7999597887dcf2d11646c52fc5cb411 Mon Sep 17 00:00:00 2001 From: Alejandro Martinez Date: Sat, 8 Oct 2016 09:50:26 -0300 Subject: [PATCH] Speedup isMetricRelevantForRides method Shortcut or is enough --- src/Core/RideCache.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/Core/RideCache.cpp b/src/Core/RideCache.cpp index 85fdd18b1..beb01b861 100644 --- a/src/Core/RideCache.cpp +++ b/src/Core/RideCache.cpp @@ -907,16 +907,14 @@ bool RideCache::isMetricRelevantForRides(Specification specification, const RideMetric* metric) { - bool isRelevant = false; - // loop through and aggregate foreach (RideItem *ride, rides_) { // skip filtered rides if (!specification.pass(ride)) continue; - isRelevant = isRelevant || metric->isRelevantForRide(ride); + if (metric->isRelevantForRide(ride)) return true; } - return isRelevant; + return false; }