"Fix" some cppcheck warnings

.. these are trivial changes that are mostly to adjust syntax
   used in the code so cppcheck doesn't get confused.

   Thanks to Bart Coddens for pointing these out.

   CppCheck is available from:
   https://www.icts.uiowa.edu/confluence/display/BRAINSPUBLIC/Using+Cppcheck+To+Produce+Better+Code

src/GcPane.cpp

@@ -18,12 +18,6 @@
 
 #include "GcPane.h"
 
-GcPane::GcPane(QLayout *p)
-{
-    GcPane();
-    setLayout(p);
-}
-
 GcPane::GcPane() : QWidget(NULL, Qt::FramelessWindowHint),
     borderWidth(4), dragState(None)
 {

src/GcPane.h

@@ -39,7 +39,6 @@ class GcPane : public QWidget
 
     public:
         GcPane();
-        GcPane(QLayout *p);
 
         void setLayout(QLayout *layout); // override standard setLayout
 

src/LTMSettings.cpp

@@ -121,7 +121,7 @@ LTMSettings::readChartXML(QDir home, bool useMetricUnits, QList<LTMSettings> &ch
 
     QXmlInputSource source( &chartsFile );
     QXmlSimpleReader xmlReader;
-    LTMChartParser( handler );
+    LTMChartParser handler;
     xmlReader.setContentHandler(&handler);
     xmlReader.setErrorHandler(&handler);
     xmlReader.parse( source );

src/LTMTool.cpp

@@ -2099,7 +2099,7 @@ LTMTool::importClicked()
             // setup XML processor
             QXmlInputSource source( &chartsFile );
             QXmlSimpleReader xmlReader;
-            LTMChartParser (handler);
+            LTMChartParser handler;
             xmlReader.setContentHandler(&handler);
             xmlReader.setErrorHandler(&handler);
 

src/Library.cpp

@@ -70,10 +70,10 @@ Library::initialise(QDir home)
             // parse it!
             QXmlInputSource source(&libraryXML);
             QXmlSimpleReader xmlReader;
-            LibraryParser(handler);
+            LibraryParser handler;
             xmlReader.setContentHandler(&handler);
             xmlReader.setErrorHandler(&handler);
-            xmlReader.parse( source );
+            xmlReader.parse(source);
             libraries = handler.getLibraries();
 
         } else {

src/NamedSearch.cpp

@@ -67,10 +67,10 @@ NamedSearches::read()
     QFile namedSearchFile(home.absolutePath() + "/namedsearches.xml");
     QXmlInputSource source( &namedSearchFile );
     QXmlSimpleReader xmlReader;
-    NamedSearchParser( handler );
+    NamedSearchParser handler;
     xmlReader.setContentHandler(&handler);
     xmlReader.setErrorHandler(&handler);
-    xmlReader.parse( source );
+    xmlReader.parse(source);
 
     // go read them!
     list = handler.getResults();

src/Season.cpp

@@ -248,7 +248,7 @@ Seasons::readSeasons()
     QFile seasonFile(home.absolutePath() + "/seasons.xml");
     QXmlInputSource source( &seasonFile );
     QXmlSimpleReader xmlReader;
-    SeasonParser( handler );
+    SeasonParser handler;
     xmlReader.setContentHandler(&handler);
     xmlReader.setErrorHandler(&handler);
     xmlReader.parse( source );