Commit Graph

1091 Commits

Author SHA1 Message Date
Mark Liversedge
d84ffec0a6 Fix RideSummaryWindow crash
The recent patch to allow users to configure which
metrics to display on the ride summary window is not
forwards compatible. If metrics referenced no longer
exist (i.e. they are from a future release or have
been deprecated) GC will crash.
2011-08-01 23:36:49 +01:00
Damien
20477e1670 Altitude scale present with no altitude data.
Uncheck the channel if not present. Fixes #295.
2011-08-01 22:17:20 +01:00
Mark Liversedge
610b2ea2d0 Remove console error for seasons.xml
There is no need to warn about seasons.xml missing, it
is quite acceptable to have none set. Worse still sending
to the console log is next to useless for users that
don't launch from the command line.

Partial cherry pick from 4972f2472e (v3.0.0dev)
2011-08-01 13:22:23 -04:00
Mark Liversedge
e7a7803f09 Fix WKO+ file reader GPS 'drops'
The WKO+ file format appears to record drops in
recording of GPS data with a latlon of 180,180. We
expect this to be 0,0.

This makes the WKO+ file reader consistent with the
GoogleMapControl and removes the need to clean data
there.

If it is found that 180,180 is the standard way of
recording drops in GPS signal then we can change the
code. We use 0,0 since it is conveniently at sea off
the west coast of Africa.

Cherry pick d06c9e97c9 (From v3.0.0dev)
2011-08-01 13:14:31 -04:00
Damien
c6a376b89f Add PeakPowerHr metric (average HR during peak power) 2011-07-28 21:12:20 +01:00
Damien
65c4d89890 Correct crash with truncated files
Fixes #337
Fixes #354
2011-07-28 12:41:55 -04:00
Rainer Clasen
1674558dbb FitRideFile: turned assertions into graceful fail
reading Fit files with Smart recording and a certain pattern of timestamps
could cause assertions. This shouldn't happen, as it's no Programming error.

Changed the checks into graceful failures.

Unfortunatly I don't have any files to test this.

fixes #364
2011-07-25 14:07:14 -04:00
Rainer Clasen
ee79a86c1f SrmRideFile: turned assertions into graceful fail
reading unsupported SRM files caused assertions. This shouldn't happen, as
it's no Programming error.

Changed the checks into graceful failures.

fixes #364
2011-07-25 14:07:07 -04:00
Mark Liversedge
92897a966b Better rounding of time in AllPlot
With realtime data there will often be samples with
timestamps like 940.002 and 940.998. This cuases an
issue on the ride plot, where it believes there is
no sample for 941 and therefore plots a zero value.

This patch rounds the timestamps to the nearest 100th
of a second, which is consistent with the mechanism
used in the ride editor.
2011-07-24 21:36:21 -04:00
Damien Grauser
ca1c4def3a O_Sync Macro X device support
Adds support for the Macro X bike computer for downloading rides
and reading/writing in the native file format (sync).

For more information on this new bike computer see:
http://www.o-synce.com/en/products/bike/macro-series/macrohigh-x.html

Fixes #357.
2011-07-24 10:44:46 +01:00
Damien
05346eda24 Add summary metrics list to preferences
Fixes #317.
2011-07-23 17:41:37 +01:00
Rainer Clasen
bea79092ab Fit: handle unknown fields gracefully
So far the FIT parser bailed out, whenever it found something
unknown/uninterested to GC. This is quite orthogonal to the FIT design, as
it's supposed to be extended.

renamed read_<foo> functions to match the FIT base_type names.

unified handling of "unavailable/invalid" values - i.e. if sensor data is
temporary unavailable. This allows easier and consistent handling -
especially for the uintXz base_types, which only differ by a different
"invalid" value. Had to change the type of the "values" list to int64 to
fit uint32/int32, as well.

added proper support for signed integer types. I'm wondering, why lon, lat
+ temperature were decoded properly...

added support for currently unsupported base types by just skipping their
bytes. This allows us to continue reading.
2011-07-23 13:57:49 +01:00
Rainer Clasen
e478c24650 Fit: support big/little endian data
... on both, big and little endian machines.

Fit reader only supported little endian data on little endian machines.

All values read from FIT files are now swapped (if neccessary) according
to file and system endianess.

fixes #287
2011-07-23 13:57:49 +01:00
Rainer Clasen
96bb21d04d Fit: ignore unknown message types
do not bail out on unknown message types. This violates the design of the
Fit format of being extensible.

As this was the last thing using the global_msg_names QMap, I've nuked
this, aswell.
2011-07-23 13:57:49 +01:00
Alejandro Martinez
65615295c2 Add HrZones to Weekly Summary and Fix Spanish Translation
Fixes 344.
2011-07-23 12:09:18 +01:00
Rainer Clasen
b21d24039c fix reading signed values from srm files
seems, the assumption for "speed" in SRM7 files being unsigned was wrong.
Powercontrol/SRMWIN seem to use negative speed as "invalid".

Furthermore altitude may become negative, as well.

To address this, QDataStream now does the bit-swapping and speed +
altitude are read as signed values.

Fixes 346.
2011-07-23 12:08:56 +01:00
Rainer Clasen
c25f920062 whitespace cleanup
unfortunatly my latest patches introduced some tabs. Replaced them with
spaces to meet GC indent style.

Fixes 347.
2011-07-23 12:08:56 +01:00
Alejandro Martinez
7f2b6dd793 Set UTF-8 in charts,metadata and seasons xml files
Fixes 345
2011-07-23 12:08:56 +01:00
Damien
148390ea61 handle showHr/Speed/Cad/Alt state for stacked view
Fixes 130.
2011-07-23 12:08:56 +01:00
Gareth Coco
c525a36ea5 Change start date from UTC to localtime for bin ride file
Fixes 338.
2011-07-23 12:08:56 +01:00
Damien Grauser
627595175f Update French translation. 2011-06-07 22:31:47 +01:00
Alejandro Martinez
09365a8b24 Add Spanish Translation & Fix Translation Issues
This patch:
* Add Spanish Translation
* Enable default Zone Descriptions Translation
* Enable Color Selection Translation
* Enable PM Metrics and Metric Detail Dialog Translation
* Enable Data Processor Translation
* Enable Metrics Translation
* Enable Metadata Translation
* Enable Several Incomplete Translations
* Add default lang selection based on locale
* Fix Trend-Watts translation Add units default
* Translate Download Instructions
* Add default charts translation

Notes:
1. If ENABLE_METRICS_TRANSLATION is defined, the code setting metric names
   and units is moved from constructors to initialize method, to be called
   after translator initialization, English Name is preserved as InternalName
   for metadata.xlm compatibility in metric override.

2. Q_DECLARE_TR_FUNCTIONS(class-name) macro is used to set tr() context
   when class-name is not QObject sub-class.
2011-06-05 17:46:46 +01:00
Mark Liversedge
8ae7a3f738 Fix WKO parser for Ergomo users
The WKO ride file reader used wrong constants for the bit
field size of the sample data when decoding files from
Ergomo devices.

Fixes #335.
2011-05-25 20:04:19 +01:00
Mark Liversedge
2ef0533ec3 Revert "Add Spanish Translation and Enable Metrics Translation"
This reverts commit 1fbaeae611.

Accidentally pushed to the main repository along with recent
patch fixups. Ale is working on a complete solution for
supporting translations in metrics, metadata and configuration
settings. This patch was an initial version and should not
have been pushed to master.
2011-05-23 21:37:08 +01:00
Mark Liversedge
b7632a4173 Fix Virtual Power for Fluid2
Fix was applied to v3 but not v2, an oversight on my part.
The patch is now applied to the current master for v2 users.

Fixes #270.
2011-05-23 21:09:51 +01:00
Mark Liversedge
29fa978b8f Fix Wko GPS parsing on 64bit
This bug recently fixed in v3 is also present in the
v2 code.

Fixes #214.
2011-05-23 20:24:57 +01:00
Alejandro Martinez
1fbaeae611 Add Spanish Translation and Enable Metrics Translation
Add Spanish Translation.
If ENABLE_METRICS_TRANSLATION is defined, the code setting metric names
and units is moved from constructors to initialize method to be called
after translator initialization and QObject::tr(s) calls are replaced by
QApplication::translate("class name",s) to set appropiate context.
Metric symbol is used for symbol override instead of metric name.
2011-05-17 19:28:56 +01:00
Tim Shaffer
d91337e18d Make the default date range for Performance Manager a user preference. 2011-03-02 21:07:50 +00:00
Gareth Coco
88967c1588 Set default Smoothing (secs) in Ride Plot to one (1) second
Fixes #145
2011-03-01 21:30:12 +00:00
Mark Liversedge
dd7af03785 Updated Czech translation
Thanks to David Kramar for an updated version of the
Czech translation files. This provides 100% of texts
translated.
2011-03-01 21:08:31 +00:00
Damien
0c1353aa39 Remove error logs for unused datas in ride file
Fixes #173
2011-02-27 11:07:49 +00:00
Ilja Booij
8cb592d6b4 fix 'Wrong distance on Tacx caf file import'
This fixes wrong distance on Tacx by taking distance of first data
point as the base, and basing all distances on that first point.

Fixes #204
2011-02-27 11:07:49 +00:00
kohasa
09bec66b38 enabled editing interval duration by keyboard.
Fixes #125
2011-02-27 11:07:48 +00:00
Gareth Coco
c4f379d12c FIT file reader fixes
1. Allow FIT reader to recognise the file comes from a Garmin Edge 800
This is Garmin product ID 1169 in the decodeFileId routine.

2. Ignore global_msg_type = 72
This message appeared with the introduction of the Garmin Edge 800.
There is no FIT SDK that tells us what this message is.
It appears only once and has timestamp/device serial number.
Code now recognises the msg_type as valid but we don't process it.

3. Add all decodeEvent types and work only with "timer" events
Not all event_types were present. They are now all in the function.
Previously the decodeEvent would look at all "events"
We now only decode event_types if the event is of type "timer".

Fixes: #250
2011-02-26 14:09:30 +00:00
Gareth Coco
1101e7e62b Changes to map markers
1. Removed green begin marker
2. Change interval markers 2 and higher to be blue
2011-02-26 14:09:30 +00:00
Greg Lonnon
7aceb4f0f3 Added a QFilesystemWatcher to monitor adding files to the workout directory.
This allows the TrainTool to automatically pick up any changes added to
the directory
2011-02-26 14:09:30 +00:00
Rainer Clasen
57b9e28110 Added SRM5 file format read support
SRM5 basically is the same as SRM6, but lacks "blocks". This means, it
only has the date of the exercise and no further absolute time info.
Furthermore it can't flag periods of time, where no data was collected.

Due to lack of absolute time, Exercises start at 0:00, by default.

Fixes #208
2011-02-26 14:08:54 +00:00
unknown
0bf19e3e8d This patch correct altitude for TCX files converted from FIT files These files doesn't have altitude for each Trackpoints. I propose to not assign 0 to altitude before each trackpoint
Fixes #60
2011-02-26 14:07:53 +00:00
Eric Brandt
6815fe0d1f fix realtime mode load timer and lcd sig. digit display issues
The load timer was simply being accumulated with each firing
of the timer. This resulted in inaccuracies. The fix is to
accumulate using a timer that measures the duration between loadUpdate
calls.

The speed, average speed, gradient, and distance LCDs ought to always
display 1 significant digit to avoid bouncing. This is now fixed.

This commit fixes #262 and fixes #263.
2011-02-14 22:05:42 +00:00
Mark Liversedge
8913b37346 Fix 'Save data' in RealtimeWindow
A previous commit stopped disk updating from working, i.e. saving
workout data to a .csv file. This patch fixes that.

Fix supplied by Greg Lonnon, Fixes #254.
2011-02-07 19:48:31 +00:00
Mark Liversedge
3ff839c4ff Fix Computrainer with Stereo FTDI adaptor
The newer Racermate FTDI based USB adaptor (USB-StereoJack) failed
to receive data from the Computrainer, this was due to incorrect
flow control settings.

Fix supplied by Eric Brandt.
2011-02-07 19:25:25 +00:00
Damien
470885df50 Modify csv import for ergomo file with comma or semicolon separator
Fixes #244.
2011-01-30 15:50:24 +00:00
Darren Hague
152239eea4 Remove toMSecsSinceEpoch() and work around
toMSecsSinceEpoch() is from Qt 4.7. Replaced with an implementation
based on QTime:start() and QTime.elapsed() from Qt 4.6.
There is now a theoretical upper limit on turbo sessions of 24 hrs :-)

Fixes #247.
2011-01-30 15:14:13 +00:00
Darren Hague
073079a6e7 Add virtual power support for BT-ATS trainer
Add "BT Advanced Training System" to dropdown.
Implement 3rd-order polynomial to get power from speed.

Fixes #246.
2011-01-30 14:43:11 +00:00
Darren Hague
963c28c7a8 Use realtime clock for realtime-mode clock
Instead of adding 200ms to the elapsed time on every gui update,
this patch records the timestamp of when the Start/Pause buttons
are clicked and subtracts these from the current hardware clock time
to calculate elapsed total & lap times.  Fixes bug #235.
2011-01-22 20:24:52 +00:00
Darren Hague
7e42cdd486 Corrected - to + in CycleOps formula
Fixes #239
2011-01-22 20:24:52 +00:00
Mark Liversedge
c1fc674609 Translations Bonanza!
Russian Translation from Gwelu
Czech Translation from Beeda
Updated Japanese Translation courtesy of Key
Updated German Translation courtesy of Luke

Golden Cheetah now supports 7 languages!
2011-01-22 20:19:42 +00:00
Darren Hague
615737658d Virtual Power; Better GSC-10 pairing support.
Virtual Power - included patch from Mark Liversedge & corrected bug
with his help.

GSC-10: Check dual sensor 4th and speed-only sensor (which is rare) as
5th.
This means that an all-Garmin setup (ANT+ stick, GSC-10 sensor) will
always work. A speed-only sensor is almost useless in GC real-time
mode anyway, because speed-only sensors tend to run off the front
wheel which will be stationary on a trainer. Fix pointer problems with
device controller/config.

Fixes #219
2011-01-09 19:15:20 +00:00
Justin Knotzke
3cab2f6175 Update of German translation by LukeNRG 2011-01-06 17:36:20 -05:00
Greg Lonnon
93ad436c6a changes to the markers in google maps.
blue marker = start of ride
red marker = end of ride
green markers = interval markers.

interval markers has the interval metrics displayed.
end marker has the ride summary displayed.

Fixes #169.
2011-01-02 17:21:17 +00:00