It corrects removal of threading support against the 2.3.3.4
head. This is required for Windows builds at present.
I also added an INDEX in the contrib directory for all the
other things we've snaffled into the repository.
.. now we've optimised out the model resets the diary window
(calendar chart) needs to explicitly repaint when a ride is
selected because the model won't reset unless the ride selected
is for a different month to the one currently shown.
.. lots of unneccessary setting of dates and refreshing optimised out.
.. but probably more lurking coz we handle updates from all over the
place and worse to miss one than do it twice in most cases.
This reverts commit 6fdc55528f.
The performance decrease is considerable. Using mallocs across
my personal ride collection takes 5:19 to compute all the caches.
Using the QVector equivalent took 22:40.
Need to consider looking at QVector across the GC codebase.
.. will refresh after the metrics and cpx have been refreshed
.. it invalidates the data rather than refreshing immediately
since thats expensive and better wait until refresh is needed.
If an incore cache of an aggregated RideFileCache is invalidated
by a ride in the same period being edited it does not clear
until the cache array is cleared (25 of them so likely to be
never) or upon a restart.
This fixes them being invalidated by refreshCache.
When GC is restarted after being closed full screen, the saved geometry
is larger than the actual screen size - resulting in the title bar being
drawn off screen & not easily reachable.
This patch checks whether the saved geometry is larger than the current
screen size, and resizes to the screen size instead of the saved values.
.. actually it was an uninitialized variable bug introduced
by the earlier fix for the calendar model.
Caused by new code checking if an index was -1 before setting
it, but forgetting to initialise it to -1 to begin with.
Fixes#531.
.. it turns out the translation for Data and Date are both
Data!
.. we now use the first column that matches when seeking special
fields. This is a bit of a hack, but good enough for now.
Fixes#530.
When youi switch to Diary view no date range is known by the
charts because they have just been created. Since we have a
lazy create we need to resignal the date range after they
are created.
This was already in MainWindow with a call to GcCalendar::refresh
but a recent update optimised that out.
The search/filter selects in the activity list but doesn't
highlight the rides on the calendar.
This patch highlights the dates that have activities that
match with a red border and a red number.
After download fails a .strava file is left in the
athlete directory. This is picked up on restart and
causes a crash.
We now create the temporary file in a temporary
directory to avoid this issue.
Fixes#525.
.. example on the cover page of the manual
.. we need them to follow a naming convention
if section-keyword.pdf, e.g. 0-icon.pdf for
the icon on the title page (section 0).
After taking out the double refresh in the previous commit
we got a bug with the last selected date stating highlighted
when clicking on the left and right buttons.
Fixed by signalling date changes after the model has been
queried. Still lots faster than before.