nmelone/GoldenCheetah
1
0
Fork 0
mirror of https://github.com/GoldenCheetah/GoldenCheetah.git synced 2026-04-15 05:32:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

REGRESS: Remove translateMetrics() from LTMPlot

Browse Source 
This is a regression to remove the metric translation
functionality from LTMPlot.

WE WILL REINTRODUCE BEFORE RELEASE!

It has been regressed because;

1. It crashes on QT5 with Win32

2. It has significant performance penalties;

   It really should not instantiate an LTMTool object
   (Ale did discuss this with me and I gave it the go
   ahead, so my bad).

3. It should be executed on applySettings() not on
   each refreshPlot().

4. It has a bug regarding uunits being lost and breaking
   sharing of a common axis.
This commit is contained in:
Mark Liversedge
2013-12-10 19:54:00 +00:00
parent 2bf20369d9
commit ea281ba057
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/LTMPlot.cpp
View File

@@ -144,7 +144,7 @@ LTMPlot::setData(LTMSettings *set)
settings = set;
// For each metric in chart, translate units and name if default uname
LTMTool::translateMetrics(context, settings);
//XXX BROKEN XXX LTMTool::translateMetrics(context, settings);
// crop dates to at least within a year of the data available, but only if we have some data
if (settings->data != NULL && (*settings->data).count() != 0) {