nmelone/GoldenCheetah
1
0
Fork 0
mirror of https://github.com/GoldenCheetah/GoldenCheetah.git synced 2026-04-15 05:32:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Charts/PfPvPlot (QA): allow vertical scales up to 2500N (#4444)

Browse Source 
The vertical axis on the QA plots (pedal force, Newtons) was stuck at
600N, even if the ride data exceeded it. The code that calculated the
max force for the activity was apperently trying to throw out outliers
(defined as "more than 2500N" -- 562 lbf)... but when finding the "max
force" the value was seems to have accidentally been typed in as
"255". This created logically dead code:

    maxAEPF = 600;
    ...
    if (aepf < 255 && aepf > maxAEPF) maxAEPF = aepf;

Thus, the max is never updated.

This patch changes the filter value from 255 to 2500 (as is indicated
to be the intent elsewhere in the source file).
This commit is contained in:
Gabriel M. Beddingfield
2024-02-04 12:04:52 -08:00
committed by GitHub
parent 76922846f8
commit d335ff425c
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Charts/PfPvPlot.cpp
View File

@@ -1073,7 +1073,7 @@ PfPvPlot::recalc()
double aepf = (p1->watts * 60.0) / (p1->cad * cl_ * 2.0 * PI);
double cpv = (p1->cad * cl_ * 2.0 * PI) / 60.0;
if (aepf < 255 && aepf > maxAEPF) maxAEPF = aepf;
if (aepf < 2500 && aepf > maxAEPF) maxAEPF = aepf;
if (cpv > maxCPV) maxCPV = cpv;
}
}