Code Cleanup: Ride Data and Friends

.. cleaning XXX and misleading comments

src/RideEditor.cpp

@@ -1253,8 +1253,8 @@ RideEditor::endCommand(bool undo, RideCommand *cmd)
 
             // move cursor to point updated
             QModelIndex cursor = model->index(spv->row, model->columnFor(spv->series));
-            // NOTE: This is to circumvent a performance issue with multiple
-            //       calls to setCurrentIndex XXX still TODO...
+            // NOTE: This is to circumvent a performance issue with multiple calls to setCurrentIndex 
+
             if (inLUW) { // remember and do it at the end -- otherwise major performance impact!!
                 itemselection << cursor;
             } else {

src/RideFileCache.cpp

@@ -78,9 +78,6 @@ RideFileCache::RideFileCache(MainWindow *main, QString fileName, RideFile *passe
             // is it as recent as we are?
             if (head.version == RideFileCacheVersion) {
 
-                // Are the CP/LTHR values still correct
-                // XXX todo
-
                 // WE'RE GOOD
                 if (check == false) readCache(); // if check is false we aren't just checking
                 return;
@@ -483,8 +480,8 @@ void RideFileCache::RideFileCache::compute()
 data_t *
 MeanMaxComputer::integrate_series(cpintdata &data)
 {
-
-    data_t *integrated= (data_t *)malloc(sizeof(data_t)*(data.points.size()+1)); //XXX use QVector... todo
+    // would be better to do pure QT and use QVector -- but no memory leak
+    data_t *integrated= (data_t *)malloc(sizeof(data_t)*(data.points.size()+1)); 
     int i;
     data_t acc=0;
 

src/RideMetadata.cpp

@@ -53,15 +53,10 @@ RideMetadata::RideMetadata(MainWindow *parent, bool singlecolumn) :
     tabs->setMovable(true);
     tabs->setPalette(palette);
     tabs->setAutoFillBackground(false);
-#if 0
-    tabs->setStyleSheet("QTabBar { alignment: center; }"
-                          "QTabWidget::pane { top: 0px; }"
-                       );
-#endif
     mainLayout->addWidget(tabs);
 
     // read in metadata.xml and setup the tabs etc
-    qRegisterMetaType<RideItem*>("ride"); // XXX we're first here... bit of a hack
+    qRegisterMetaType<RideItem*>("ride");
 
     extraForm = new Form(this);
 
@@ -441,8 +436,6 @@ FormField::FormField(FieldDefinition field, RideMetadata *meta) : definition(fie
 
         if (field.name == "Change History") {
             dynamic_cast<QTextEdit*>(widget)->setReadOnly(true);
-            // pick up when ride saved - since it gets updated then
-            // XXX ? connect (main, SIGNAL(rideClean()), this, SLOT(rideSelected()));
         } else {
             connect (widget, SIGNAL(textChanged()), this, SLOT(editFinished()));
         }

src/RideSummaryWindow.cpp

@@ -127,8 +127,7 @@ RideSummaryWindow::metadataChanged()
 void
 RideSummaryWindow::refresh()
 {
-    // XXX: activeTab is never equaly to RideSummaryWindow right now because
-    // it's wrapped in the summarySplitter in MainWindow.
+    // if we're summarising a ride but have no ride to summarise
     if (ridesummary && !myRideItem) {
 	    rideSummary->page()->mainFrame()->setHtml("");
         return;
@@ -360,7 +359,7 @@ RideSummaryWindow::htmlSummary() const
             else time_in_zone[i] = SummaryMetrics::getAggregated(timeInZones[i], data, useMetricUnits, true).toDouble();
         }
         summary += tr("<h3>Power Zones</h3>");
-        summary += mainWindow->zones()->summarize(rideItem->zoneRange(), time_in_zone); //XXX aggregating?
+        summary += mainWindow->zones()->summarize(rideItem->zoneRange(), time_in_zone); //aggregating
     }
 
     //
@@ -376,7 +375,7 @@ RideSummaryWindow::htmlSummary() const
         }
 
         summary += tr("<h3>Heart Rate Zones</h3>");
-        summary += mainWindow->hrZones()->summarize(rideItem->hrZoneRange(), time_in_zone); //XXX aggregating
+        summary += mainWindow->hrZones()->summarize(rideItem->hrZoneRange(), time_in_zone); //aggregating
     }
 
     // Only get interval summary for a ride summary