nmelone/GoldenCheetah
1
0
Fork 0
mirror of https://github.com/GoldenCheetah/GoldenCheetah.git synced 2026-02-13 16:18:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Overview BubbleViz refresh bug

Browse Source 
.. since axis min and max values were not initialised the
   visualisation would fail to refresh and was generally
   unpredictable.

.. we now set initial values and check when updating.
This commit is contained in:
Mark Liversedge
2021-08-05 18:05:51 +01:00
parent b36bbdc3c0
commit 62012f1990
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Charts/OverviewItems.cpp
View File

@@ -2054,7 +2054,6 @@ IntervalOverviewItem::setDateRange(DateRange dr)
first = false;
}
// set scale
double ydiff = (maxy-miny) / 10.0f;
if (miny >= 0 && ydiff > miny) miny = ydiff;
@@ -3826,6 +3825,8 @@ BubbleViz::BubbleViz(IntervalOverviewItem *parent, QString name) : QGraphicsItem
transitionAnimation=new QPropertyAnimation(this, "transition");
group->addAnimation(transitionAnimation);
minx=maxx=miny=maxy=-1; // initial values
}
BubbleViz::~BubbleViz()
@@ -3906,6 +3907,14 @@ bool scoresBiggerThan(const BubbleVizTuple i1, const BubbleVizTuple i2)
void
BubbleViz::setPoints(QList<BPointF> p, double minx, double maxx, double miny, double maxy)
{
// initial conditions?
if (this->miny == -1 && this->maxy == -1 && this->minx == -1 && this->maxx == -1) {
this->minx=minx;
this->miny=miny;
this->maxy=maxy;
this->maxx=maxx;
}
xaxisAnimation->setStartValue(QPointF(this->minx,this->maxx));
xaxisAnimation->setEndValue(QPointF(minx,maxx));
yaxisAnimation->setStartValue(QPointF(this->miny,this->maxy));
@@ -4124,6 +4133,7 @@ BubbleViz::paint(QPainter*painter, const QStyleOptionGraphicsItem *, QWidget*)
}
} else {
// when transition is -1 we are rescaling the axes first
int index=0;
foreach(BPointF point, oldpoints) {