nmelone/GoldenCheetah
1
0
Fork 0
mirror of https://github.com/GoldenCheetah/GoldenCheetah.git synced 2026-04-15 05:32:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

FIT parser bounds check when adding new series

Browse Source 
.. needs to be less than XDATA_MAXVALUES
This commit is contained in:
Mark Liversedge
2023-11-10 18:40:38 +00:00
parent 943deb67ea
commit 5fb3bbfbbf
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/FileIO/FitRideFile.cpp
View File

@@ -1895,16 +1895,18 @@ struct FitFileParser
// the XDATA section, so lets see if it is a start_time field?
if (strcmp(metadata.name.c_str(), "start_time") == 0) timestamp = value;
// add the xdata series if not present yet
seriesindex=xdseries->valuename.indexOf(metadata.name.c_str());
if (seriesindex == -1) {
xdseries->valuename.append(metadata.name.c_str());
xdseries->unitname.append(metadata.unit.c_str());
xdseries->valuetype.append(RideFile::SeriesType::none); // makes no sense, if it was a series type it wouldn't be xdata
// add the xdata series if not present yet, guarding against hitting the maximum
if (xdseries->valuename.count() < XDATA_MAXVALUES) {
seriesindex=xdseries->valuename.indexOf(metadata.name.c_str());
if (seriesindex == -1) {
xdseries->valuename.append(metadata.name.c_str());
xdseries->unitname.append(metadata.unit.c_str());
xdseries->valuetype.append(RideFile::SeriesType::none); // makes no sense, if it was a series type it wouldn't be xdata
seriesindex=xdseries->valuename.indexOf(metadata.name.c_str());
}
add->number[seriesindex] = scaledvalue;
count++;
}
add->number[seriesindex] = scaledvalue;
count++;
if (FIT_DEBUG && FIT_DEBUG_LEVEL>3) {
fprintf(stderr, "decodeGeneric(%s) %d: %s field %d bytes, num %d, type %s [%s]=%f %s\n",