nmelone/GoldenCheetah
1
0
Fork 0
mirror of https://github.com/GoldenCheetah/GoldenCheetah.git synced 2026-04-15 05:32:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid crashes on Trends Overview when metric is unavailable

Browse Source 
Metric, TopN and Donut crash on setData when the base metric
is not available, for example when a User Metric was removed.
This commit is contained in:
Ale Martinez
2020-08-24 19:12:11 -03:00
parent 203c505f34
commit 42632c4d8d
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Charts/OverviewItems.cpp
View File

@@ -695,6 +695,8 @@ MetricOverviewItem::setData(RideItem *item)
void
MetricOverviewItem::setDateRange(DateRange dr)
{
if (!metric) return; // avoid crashes when metric is not available
// for metrics lets truncate to today
if (dr.to > QDate::currentDate()) dr.to = QDate::currentDate();
@@ -816,6 +818,8 @@ static bool entrylessthan(struct topnentry &a, const topnentry &b)
void
TopNOverviewItem::setDateRange(DateRange dr)
{
if (!metric) return; // avoid crashes when metric is not available
// clear out the old values
ranked.clear();
@@ -985,6 +989,8 @@ static bool lessthan(const aggmeta &a, const aggmeta &b)
void
DonutOverviewItem::setDateRange(DateRange dr)
{
if (!metric) return; // avoid crashes when metric is not available
// stop any animation before starting, just in case- stops a crash
// when we update a chart in the middle of its animation
if (chart) chart->setAnimationOptions(QChart::NoAnimation);;