nmelone/GoldenCheetah
1
0
Fork 0
mirror of https://github.com/GoldenCheetah/GoldenCheetah.git synced 2026-04-15 05:32:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Qt6: Preventing crash in stacked LTMPlots (#4483)

Browse Source 
In Qt6 the internal handling of QList (now actually a QVector) was
changed compared to Qt5. This results in reallocations / recreations of
the LTMSettings, destroying the objects whose pointers already have been
set to the LTMPlots.
This commit reserves the required space upfront, preventing the
reallocations thus keeping the pointers valid and preventing the crash
This commit is contained in:
Joachim Kohlhammer
2024-05-04 17:59:06 +02:00
committed by GitHub
parent 7a11a6abd4
commit 3e8ddd9f29
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Charts/LTMWindow.cpp
View File

@@ -785,8 +785,11 @@ LTMWindow::refreshCompare()
int position = 0;
// create ltmPlot with this
// Reserving space in list to prevent reallocations and reorderings that break the pointers
// to the LTMSettings
if (plotSetting.metrics.count()) {
compareplotSettings.reserve(1 + settings.metrics.size());
compareplotSettings << plotSetting;
// create and setup the plot
@@ -797,6 +800,8 @@ LTMWindow::refreshCompare()
// now add
compareplotsLayout->addWidget(stacked);
compareplots << stacked;
} else {
compareplotSettings.reserve(settings.metrics.size());
}
// OK, now one plot for each curve
@@ -888,8 +893,11 @@ LTMWindow::refreshStackPlots()
int position = 0;
// create ltmPlot with this
// Reserving space in list to prevent reallocations and reorderings that break the pointers
// to the LTMSettings
if (plotSetting.metrics.count()) {
plotSettings.reserve(1 + settings.metrics.size());
plotSettings << plotSetting;
// create and setup the plot
@@ -900,6 +908,8 @@ LTMWindow::refreshStackPlots()
// now add
plotsLayout->addWidget(stacked);
plots << stacked;
} else {
plotSettings.reserve(settings.metrics.size());
}
// OK, now one plot for each curve