nmelone/GoldenCheetah
1
0
Fork 0
mirror of https://github.com/GoldenCheetah/GoldenCheetah.git synced 2026-04-13 12:42:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Compile time nits

Browse Source 
.. cleaning out warnings.
This commit is contained in:
Mark Liversedge
2016-03-06 08:57:24 +00:00
parent 81f30eed4c
commit 3399a4dc6f
3 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Cloud/CloudDBCommon.cpp
View File

@@ -482,8 +482,8 @@ CloudDBHeader::getAllCachedHeader(QList<CommonAPIHeaderV1> *objectHeader, CloudD
QMutableListIterator<CommonAPIHeaderV1> it(*objectHeader);
while (it.hasNext()) {
CommonAPIHeaderV1 header = it.next();
if (header.Id > 0 && updatedIds.contains(header.Id) ||
header.Key.size() > 0 && updatedStringIds.contains(header.Key)) {
if ((header.Id > 0 && updatedIds.contains(header.Id)) ||
(header.Key.size() > 0 && updatedStringIds.contains(header.Key))) {
// update cache (Header Cache)
it.remove();
}

4
src/Train/ErgFile.cpp
View File

@@ -50,7 +50,7 @@ bool ErgFile::isWorkout(QString name)
return false;
}
ErgFile::ErgFile(QString filename, int mode, Context *context) :
filename(filename), context(context), mode(mode)
filename(filename), mode(mode), context(context)
{
if (context->athlete->zones(false)) {
int zonerange = context->athlete->zones(false)->whichRange(QDateTime::currentDateTime().date());
@@ -59,7 +59,7 @@ ErgFile::ErgFile(QString filename, int mode, Context *context) :
reload();
}
ErgFile::ErgFile(Context *context) : context(context), mode(nomode)
ErgFile::ErgFile(Context *context) : mode(nomode), context(context)
{
if (context->athlete->zones(false)) {
int zonerange = context->athlete->zones(false)->whichRange(QDateTime::currentDateTime().date());

5
src/Train/VideoWindow.cpp
View File

@@ -45,7 +45,10 @@ VideoWindow::VideoWindow(Context *context) :
//
#ifndef Q_CC_MSVC
#if QT_VERSION >= 0x050000
#warning "WARNING: Please ensure the VLC QT4 plugin (gui/libqt4_plugin) is NOT available as it will cause GC to crash."
// we no longer warn here since it is a runtime issue, on some Ubuntu platforms
// the VLC plugin cache is out of date and needs refreshing with the command:
// $ sudo /usr/lib/vlc/vlc-cache-gen -f /usr/lib/vlc/plugins/
// #warning "WARNING: Please ensure the VLC QT4 plugin (gui/libqt4_plugin) is NOT available as it will cause GC to crash."
#endif
#endif