nmelone/GoldenCheetah
1
0
Fork 0
mirror of https://github.com/GoldenCheetah/GoldenCheetah.git synced 2026-04-15 05:32:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Banister fitting windows

Browse Source 
.. split if no gaps in seasons and combine if seasons
   are too short.

.. this way we get fairly stable fits (2yr window size)
   but also get to see parameters reflect aging, so
   p0 declines and k1/k2 fit better.

.. still need to think how t1/t2 should adjust...
This commit is contained in:
Mark Liversedge
2019-01-14 10:46:54 +00:00
parent 05a8c49053
commit 1148e3aa69
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/Metrics/Banister.cpp
View File

@@ -60,7 +60,7 @@ const double typical_CP = 261,
// used to control breaking into windows, but the performance is good enough
// that we don't need to, and more data stops the fit from going bad.
const int typical_SeasonBreak = 42;
const int typical_SeasonSize = 10000; // set so high windows never happen
const int typical_SeasonSize = 700; // a good couple of years needed
// for debugging
#ifndef BANISTER_DEBUG
@@ -392,16 +392,15 @@ Banister::refresh()
}
//
// EXPAND A FITTING WINDOW WHERE <5 TESTS (5 just not enough to get going...)
// EXPAND A FITTING WINDOW
//
int i=0;
while(i < windows.length() && windows.count() > 1) {
for(int i=windows.count()-1; i>0 && windows.count() > 1; i--) {
// combine and remove prior
if (windows[i].tests < 5 && i>0) {
if (windows[i].tests < 5 || windows[i].stopIndex-windows[i].startIndex < typical_SeasonSize) {
windows[i].combine(windows[i-1]);
windows.removeAt(--i);
} else i++;
windows.removeAt(i-1);
}
}
foreach(banisterFit f, windows) {