From c33a23404805bfd1a49d109be7d40cede48b9d8a Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Sat, 6 Apr 2024 09:15:40 -1000 Subject: [PATCH] Make eager_start default to True for async_create_task (#114995) --- homeassistant/core.py | 2 +- tests/test_core.py | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/homeassistant/core.py b/homeassistant/core.py index 48036de519e..7e09363178d 100644 --- a/homeassistant/core.py +++ b/homeassistant/core.py @@ -719,7 +719,7 @@ class HomeAssistant: self, target: Coroutine[Any, Any, _R], name: str | None = None, - eager_start: bool = False, + eager_start: bool = True, ) -> asyncio.Task[_R]: """Create a task from within the event loop. diff --git a/tests/test_core.py b/tests/test_core.py index 44da9695fdc..e9d8d39ce18 100644 --- a/tests/test_core.py +++ b/tests/test_core.py @@ -327,7 +327,7 @@ async def test_async_create_task_schedule_coroutine() -> None: async def job(): pass - ha.HomeAssistant.async_create_task(hass, job()) + ha.HomeAssistant.async_create_task(hass, job(), eager_start=False) assert len(hass.loop.call_soon.mock_calls) == 0 assert len(hass.loop.create_task.mock_calls) == 1 assert len(hass.add_job.mock_calls) == 0 @@ -353,7 +353,9 @@ async def test_async_create_task_schedule_coroutine_with_name() -> None: async def job(): pass - task = ha.HomeAssistant.async_create_task(hass, job(), "named task") + task = ha.HomeAssistant.async_create_task( + hass, job(), "named task", eager_start=False + ) assert len(hass.loop.call_soon.mock_calls) == 0 assert len(hass.loop.create_task.mock_calls) == 1 assert len(hass.add_job.mock_calls) == 0