.. editing a user interval color never worked properly.
the color wasn't changed or remembered at all.
.. lots of independent bugs conspired to cause this but
mostly it was because the interval color was not
recorded in the ride file.
NOTE: files created with this release will not be
backwards compatible with earlier releases.
.. allow the user to set a flag "Performance Test" against an interval
within an activity.
.. the distinction is needed to highlight the section of an activity
that was a test (as opposed to the entire activity containing
test efforts.
.. this is so we can fit them to PD and IR models in the future
avoiding the need to use algorithms to extract TTE type efforts.
.. the update was surprisingly complex since we need to update the
ridefile to record this with the interval and also update the
ride cache as well as adding the bool to all the interval helper
functions.
.. along the way it became clear why user specified colors for
intervals were getting lost (they are not in the ridefile) and
will fix this in another post.
.. NOTE: ridefiles created with this version will not be backward
compatible with earlier versions because they contain a
new field for intervals marked as performance tests.
New OSM maps had a blank default tile server URL and they are the new default.
Also include minor change to use an existing method and to avoid currentData.
... all Tile Servers are configurable by the user - there is only a default for the "standard" OSM Tile Server, but even this default can be overwritten
... there are no dedicated Tile Servers Sources named / hard-coded, but in addition to the default OSM server 3 additional options are available for the user to configure
Why:
... tile servers either change their URL or their T&C - which happened for some of the "hard-coded" once recently - since this may happen
again in future the recent change de-couples the code from the Tile Server URL - and the availability of certain organisations providing
free tile servers
.. no need to store data in a separate class variable
since its maintained in the settings widgets
.. the bug was caused by only setting the unneccessary
QString when settings were selected in the settings
pane
.. cleaned up some debug too.
Fixes#2403
.. map is styled using "snazzymaps.com" css template
.. but it looks naff, loads slowly and adds a dependency
on embedding a QWebEngineView, which is one of the
reasons we're developing this in the first place (!)
.. it shows how to embed charts in the dashboard, so that
proxy code will be useful in the future.
.. likely to replace the google map visualisation with a
GPS route pixmap and route profile using altitude in
the next commit or two.
