Commit Graph

183 Commits

Author SHA1 Message Date
Mark Liversedge
318cebfa56 Fix time tooltip on AllPlot 2014-06-08 13:53:48 +01:00
Mark Liversedge
0ebc66ed3c Don't allow 0 smoothing in compare mode
.. we need all intervals to have a common smoothing
   applied or it breaks the charts
2014-06-08 11:58:43 +01:00
Mark Liversedge
0ba03ddf40 Turn smoothing OFF if smooth < recIntSecs
.. i.e. don't do ANY smoothing

.. last commit fixed performance but really adds
   no value to smooth data to the interval it was
   recorded at !!
2014-06-08 11:53:00 +01:00
Mark Liversedge
3a9cde8174 No smoothing applied when smooth < recIntSecs
.. its pointless

.. it is a big performance overhead

Fixes #753.
2014-06-08 11:49:09 +01:00
Mark Liversedge
28e7c83252 Fix W bal plotting by distance
.. since we only smoothed time

Fixes #803
2014-05-06 11:22:48 +01:00
Mark Liversedge
3d00cf3a74 Revert "Fix Allplot Axis Labels"
This reverts commit 80fee9d.

Since actually using showAlt, showBalance to determine if an axis
should be drawn is incorrect, since although the user has selected
it to be plotted, it might not actually be in the ride !

The real fix for this axis labels was fixed in commit 18bf28.
2014-05-04 08:47:46 +01:00
Mark Liversedge
18bf280893 Fix AllPlot Ticks Error
.. was caused by the fact the allPlot height is not set until after the
   first show, so it is zero in initial state.  We just use a default value
   in this case.
2014-04-30 13:56:56 +01:00
Mark Liversedge
80fee9debc Fix Allplot Axis Labels
.. they weren't updated when the plot was not visible due to looking
   at the curve 'isVisible()' rather than showXXX bool.
2014-04-30 11:17:31 +01:00
Mark Liversedge
d74c3a729f Fix going negative on setAlpha
.. to stop qt outputing error messages
2014-04-16 17:44:57 +01:00
Mark Liversedge
317f1b0d2d Fixup CP and AllPlot
.. CP to show % for all ride series not just watts
.. AllPlot to show calibration markers in gray
2014-04-14 22:10:53 +01:00
Mark Liversedge
9592f39d6a Add Vector data series to ride plot
.. Torque Effectiveness and Pedal Smoothness now
   added to the ride plot.
2014-04-13 19:47:21 +01:00
Mark Liversedge
41e203922a Prettier grid lines in ride plot 2014-03-30 19:48:14 +01:00
Mark Liversedge
9bca3cc44b Changing colors in Ride Plot
.. stack plots respond when colors change
.. need to work out whats wrong with allplot and fullplot
2014-03-29 12:27:25 +00:00
Mark Liversedge
0389b6ba94 Add Model to Summary
.. when summarising a date range we now show the
   model values for CP, FTP, W' et al.
2014-03-28 18:05:30 +00:00
Mark Liversedge
61be3437d7 Add IntervalHover to Histogram Chart
.. when mousing over the intervals list we
   now plot the hovered interval in gray.
2014-03-27 13:05:53 +00:00
Mark Liversedge
d69ebddb1d Anaerobic TISS
Added Anaerobic TISS from Dr Skiba to complement
the Aerobic TISS added recently.

Added to;
* Metrics
* Ride Plot
* PMC metrics
2014-03-22 10:47:44 +00:00
Mark Liversedge
41561a2403 Fix AllPlot SEGV on Compare
.. introduced by a dodgy cut and paste to support the new
   data series Aerobic TISS.
2014-03-17 22:45:23 +00:00
Mark Liversedge
89017fe2a5 Stress Metric Prototypes
Added a few new training stress metrics whilst discussing
and working on a multicomponent view of training stress.

This is all a wip falling out of discussions around stress
metrics beyond the old TSS/BikeScore models.

For now this just includes;
1. Aerobic Training Impact Scoring System on PM/PMC
2. Work (Kj) above/below CP on PM/PMC
3. Aerobic TISS on the Ride Plot

There is lots more to come; specifically around Anaerobic TISS,
looking again at polarised training and personalised training stress
based upon the individual's CP model.
2014-03-17 20:51:57 +00:00
Mark Liversedge
b051f220f7 Fix Mac SEGV
.. native widget causes issues with 4.8.5
.. rideItem->ride() needs to check rideItem is not null
2014-03-15 08:22:10 +00:00
Mark Liversedge
6fe27b18ee Less subtley on interval hover
.. just a bit easier to see with less alpha.
2014-03-11 20:37:24 +00:00
Mark Liversedge
ec770a4202 W'bal line thickness
.. should follow preferences not always be 2px wide
2014-03-01 09:43:07 +00:00
Mark Liversedge
4e9d26d2e0 Delta Watts, Torque, Cadence and HR
.. Following on from the recent update to add acceleration
   this update adds other derived data series based upon the
   rate of change.

.. Added to the ride plot and the CP plot.

Not sure of the overall utility of these updates but bear in
mind that they are targetting sprinting and track users and
analysis.

As well as the positive side of this (development of power
cadence etc) we also want to think about and collect data
on fatigue rate (possibly only power and torque)
- fatigue over time
- fatigue over pedal stroke
2014-02-25 18:44:53 +00:00
Mark Liversedge
734f690e1b Acceleration is m/s/s
.. so don't apply metric to imperial conversion and don't
   label it as km/s !
2014-02-22 13:45:01 +00:00
Mark Liversedge
0bac9299a4 Add Acceleration to the RideFileCache
.. so we can chart distribution and cp curve for it
2014-02-21 23:20:35 +00:00
Mark Liversedge
ec3ddfaaca Add Acceleration Data Series
.. to ride plot only at this point, but will add to
   CP curve etc later

.. will also need to add rate of change for HR, Cadence
   Power as well too.
2014-02-21 20:04:07 +00:00
Mark Liversedge
48ef0bc75c Scale Y-Axis on Ride Plot
.. When you click on the axis to isolate it a spanslider
   appears to let you manually adjust the axis.

.. it looks naff .. but we can tidy that up separately
2014-02-20 23:21:33 +00:00
Mark Liversedge
888bb9885b Limit the CP autosolve for W'bal
.. if its waaaay off then don't try to autosolve for
   CP .. instead just warn that W' is probably set
   incorrectly.
2014-02-14 20:19:56 +00:00
Mark Liversedge
4d02a2cf24 Fix the labels in the ride plot in QT5
.. applying the same fix that Jaime found for the erg file plot
   to the ride plot in QT5
2014-02-12 11:34:37 +00:00
Mark Liversedge
eed9bb73de WKO+ Interval Markers
Rather than skip over the 'standard' interval markers because they
have such verbose names we now plot the vertical marker only.

This is to indicate there is an interval at a particular point to
signpost to the user that they can hover over this point to get an
interval summary.
2014-02-11 18:16:34 +00:00
Mark Liversedge
00b61bc6ee Ignore entire ride interval on hover highlight
When hovering over a ride if there is an interval that defines
the entire ride (typical if coming in from WKO+) then don't
hover highlight it, since it is distracting and adds no value.
2014-02-11 17:29:38 +00:00
Mark Liversedge
d590e58e41 Ride Plot Highlight Interval on Hover
.. As you mouse over the ride plot it will now highlight
   the shortest interval that that point is within.

.. If an interval has been selected in the sidebar it will
   refrain from hover highlighting as it is distracting

.. Also fixed up the way the highlight curve works so it
   has its own axis and works regardless of the data series
   selected.
2014-02-10 19:24:04 +00:00
Mark Liversedge
65e762c228 Optimise out WPrime in AllPlot
.. it was erroneously being computed in AllPlot even
   when it wasn't selected on the plot
2014-02-08 18:54:50 +00:00
Mark Liversedge
b418a78b0d Ride Plot Isolate Curve Fixup for Compare Mode
.. a few SEGVs when restoring state to a plot that has
   been reploted / curves deleted or added etc.
2014-02-08 13:31:50 +00:00
Mark Liversedge
11b53edec1 Reference Lines only when Plotting Power
.. the stack series plots allowed reference lines to be added
   on charts that didn't actually plot power data
2014-02-08 12:28:16 +00:00
Mark Liversedge
cbd9e67ae6 Ride Plot Isolate Curve Fixup
.. reset isolation when resetting curves etc

.. added a visual cue by dulling the axis scales to grey
   when isolation is active -- to let the user see what
   happened when they moused over an axis.
2014-02-08 12:10:24 +00:00
Mark Liversedge
99062790ef Ride plot SEGV on reference lines
.. we SEGV when they are removed and we use the new
   'isolate' curve mechanism to hide/show curves

.. also now keep a track of the reference lines in the
   CurveColors class
2014-02-07 19:19:19 +00:00
Mark Liversedge
24c9ecc964 Ride Plot Isolate curve on click
.. we now isolate a curve temporarily with a click on the axis
   so you can mouse over / look at the curve on its own

.. it would be good to also 'dull' the other curves and their
   axis labels so we have a little context .. will look at that
   next .. it might not be so 'clean' though.
2014-02-07 12:22:22 +00:00
Mark Liversedge
0e1b4aa271 AllPlot Isolate on Axis Hover
.. less jarring and useful when setting a reference line
   for power as it isolates the power series.
2014-02-06 20:22:37 +00:00
Mark Liversedge
a90bbd86fa AllPlot isolate curve on mouse over
.. disabled the effect as its NASTY and flickery but saving the
   code anyway as we might do it by a mouse over the legend ??
2014-02-06 19:16:07 +00:00
Mark Liversedge
88daadd8b6 Fix shading zorder
.. so power shading doesn't hide altitude

Fixes #772
2014-02-03 20:18:09 +00:00
Mark Liversedge
f727c6270e Potentiall fix crash on Pickers
.. track and delete plot pickers.
2014-01-26 15:08:26 +00:00
Mark Liversedge
d8711a9ba1 Fix W'bal calculation
.. the optimisation was a little eager and took out
   the integration step !

.. access to PCP is now hidden behind a function so
   it is only computed when neccessary.

.. the calculation is still significantly faster than
   the old one but not as instant as the non-integrating
   version (but then it wasn't working either!).
2014-01-23 16:30:53 +00:00
Mark Liversedge
f186f7e173 Fix temperature curve
Cosmetic fixups to make sure temperature is visible
and the fill is honoured.
2014-01-23 11:42:00 +00:00
Mark Liversedge
121a4c691a Minimum CP for W'bal going negative
.. on ride plot, when W'bal is plotted we put a mesage to say
   that CP is wrong, and autosolve for W'bal to zero.

.. this patch also optimises WPrime to make it a member of the
   ridefile class and this always available (even for intervals).

.. fixed a SEGV when computing metrics for intervals by shifting
   the timestamps to always start from zero.
2014-01-22 20:48:42 +00:00
Mark Liversedge
37d8e7a603 AllPlot Paint Zones in Compare Mode
.. we should actually paint a zoned background if
   power shade zones is selected, when in compare mode.

.. but /only/ for charts that have power on them!
2014-01-06 17:51:15 +00:00
Mark Liversedge
59821597c9 Disable reference lines in compare mode
.. it has nowhere to save them.

.. we could reintroduce and save with a compare set
   when we have one of those!
2014-01-04 11:17:22 +00:00
Mark Liversedge
df15888b0b AllPlot Compare Mode
.. extending the interval compare to the allplot chart.
2014-01-03 14:59:20 +00:00
Damien
0fa9aec9cd AllPlot: Add secondary Scope to plot speed and headwind in the same together 2013-12-26 15:41:15 +01:00
Damien
533a13546b AllPlot: Handle noTemp with no smooth
fix #634
2013-12-26 00:24:53 +01:00
Damien
c4cd9ee0e6 CPintPlot: Correct AxisScale for IntervalCurve (eg. HeadWind) 2013-12-24 15:33:58 +01:00