I have made changes to the Import CSV dialog box; the new (proposed)
behaviour is as follows:
At first, the datePicker widget and OK button are disabled.
The datePicker is preset to today's date (no longer really
necessary, but the code is there).
User clicks 'choose a file' and the usual file browser appears.
If a file is selected, its creation date is stuffed into the
datePicker.
On return from the browser, the datePicker and OK buttons are re-
enabled.
User can modify the ride date, in case the file upload was not done
on ride day.
User clicks OK, the file is imported as before.
data type instead of dynamically allocating and freeing arrays. No
memory leak here, but it's an low hanging fruit type of example of
what kind of changes we can do to reduce the amount of explicit
dynamic memory management.
--jtc
in total time riding, which previously only included hours and minutes.
A few seconds over a week shouldn't account for much, but I think it's
desirable to use the same resultion for data values across the product
for consistancy if nothing else.
--jtc
bucket sizes, the power histogram often looks short and squat with a
lot of whitespace at the top because the largest bucket may be 3 - 5
minutes, but the y-axis is scaled by adding a constant 10 (minutes) to
the max.
The attached patch scales the y-axis by a factor of 1.1 (The ride plot
does the same scaling, and it appears to work well there). Now you're
able to see more detail in histogram plots as the curve is not all
squashed along the bottom of the graph.
-jtc
"about" dialog is formatted, with "GoldenCheetah is Licenced under
the GNU General Public Licence." and "Source code can be obtained
from http://goldencheetah.org/" run together in a single paragraph
because the way the line is broken after "Source".
The attached patch splits the two sentences into two separate
paragraphs, and centers the entire dialog text.
While this is subjective, I think it looks a lot better.
--jtc
This update changes the plot to use a right y axis for speed. This makes it easier to see speed differences.
Some other packages use separate y axes for each data type, but as far as I can tell, this is not available with the qwt library used by GC.
--jtc
regardless of the Units preference. This patch checks the preference
and displays it in the appropriate units.
Unlike some of the other cases, I'm checking the value of the Units
setting each time the plot/panel is displayed.
The patch also pulls the 0.62137119 magic constant into a #define
MILES_PER_KM. This constant (and it's inverse, KMS_PER_MILE), occurs
in several files, and (IMHO) really deserves to be pulled into a
separate header, but again, that's work for another day.
--jtc
deletion of the Tools (CP Calculator) Dialog, nor was the attribute
set that tells the framework to delete the dialog when it's dismissed.
Since the other dialogs use the attribute, this patch does the same.
--jtc
