Commit Graph

10558 Commits

Author SHA1 Message Date
Alejandro Martinez
1e8220237c Update Python library with missing constants for Qt Charts
Documented in the wiki. Fixes #4009
TODO: annotate is disabled and it needs work to support the different
types.
2022-08-23 11:27:42 -03:00
Alejandro Martinez
6914832c24 Snapshot builds to test Fix Elevation using Open-Elevation.com
MapQuest API reaches EOL on Aug-31, let's test the replacement
in all the supported platforms.
Reveal Controls are disabled in this build for all charts,
with Show Console on chart settings for R and Python charts.
[publish binaries]
2022-08-22 18:49:53 -03:00
Alejandro Martinez
07f672ff80 Add GC_ALIGN_NONE to Python Library
[skip ci]
2022-08-22 10:05:38 -03:00
Alejandro Martinez
d58c539c00 User Chart Axis Settings - Show/Hide log option
According to Axis type, currently it is supported
for continuous axis only.
2022-08-21 19:05:55 -03:00
Alejandro Martinez
a0a2b28629 Update user chart dialogs for the wiki
[skip ci]
Fixes #4115
2022-08-21 19:04:56 -03:00
Alejandro Martinez
3a34f7ce55 FixElevation - Change MapQuest to Open-Elevation (#4258)
Since MapQuest elevation service reaches end of life on aug-31,
it is replaced by Open-Elevation public API with minimum changes.
TODO: use Post instead of Get to request more points at a time
Fixes #4206
2022-08-20 12:17:56 -03:00
Mark Liversedge
84eceebd00 Fix metric refresh SEGV
.. when athlete has < 10 activies modulo 0 causes arithmetic
   operation crash (divide by zero).
2022-08-17 23:20:42 +01:00
Mark Liversedge
853e248383 FIT nongarmin.json remove duplicate entries
.. added same rows twice in error.

[skip ci]
2022-08-17 14:28:32 +01:00
Mark Liversedge
ce089de33e FITmetadata.json
.. clarify how to make updates in the README

.. replace the fit_example.h from the current SDK

.. added Garmin devices not yet supported in the SDK to
   the nongarmin.json file

.. updated the makefile to use python3 and update when
   the python program is changed.
2022-08-17 14:20:16 +01:00
Alejandro Martinez
3180a166d8 Disable Reveal Controls
For R and Python charts the Show Console setting is now
part of regular settings, and it is replaced by a warning
label when R or Python are disabled to help users.
Since for remaining charts reveal controls are redundant,
they are globally disabled in Perspective class.
TODO: remove all reveal code to simplify charts,
eventually after v3.6 release to minimize risks?
Fixes #4256
2022-08-14 21:12:10 -03:00
Alejandro Martinez
f3b78338ac Update German translation
Contributed by Marcen at the forum
2022-08-14 17:42:10 -03:00
Alejandro Martinez
02cab3029b Travis-ci - cache macOS app package
[skip AppVeyor]
To avoid rebuild when after_success is cancelled,
so restarting the job can complete the packaging.
Drawback is we need to clear the cache to rebuild
[publish binaries]
2022-08-13 16:41:37 -03:00
Mark Liversedge
47355d17fe V3.6-RC2 Build Trigger
[publish binaries]
2022-08-13 11:22:12 +01:00
Mark Liversedge
d8dc986c1e VERSION 3.6 RELEASE CANDIDATE 2 AUGUST 2022
.. second release candidate with no open defects in the
   backlog for 3.6 this is likely the last release candidate
   before we release (unless we find a major defect that
   needs to be corrected and tested).
v3.5-RC2 v3.6-RC2
2022-08-13 10:28:22 +01:00
Alejandro Martinez
e3611455e4 Add default metadata.xml to Athlete config on upgrade
To incorporate new metadata supported in v3.6 to global metadata.xml
for existing users, for new users we use default as before.
Fixes #3913
2022-08-12 15:55:56 -03:00
Alejandro Martinez
d4f382e35d Simplify default named filters
isRide is new for v3.6, <>0 is redundant
2022-08-12 11:26:59 -03:00
Alejandro Martinez
3bbd6ca334 Fix Triathlon and Measure default Trends perspectives
Colors and TriMix
2022-08-11 15:23:11 -03:00
Alejandro Martinez
d21ea7b26b Update toolbar image for the wiki
[skip ci]
2022-08-11 11:44:32 -03:00
Alejandro Martinez
4065534882 Add Perspectives to Default Trends Layout
- General is what we have with updated default Trends Overview minus
CP related charts moved to Power Duration perspective.
- Power Duration includes CP related charts in previous layout plus
some useful charts from CloudDB for modelling and profiling.
- Triathlon includes a multisport Overview, TriScore PMC, VO2 Scores
for Bike and Run, CV chart for run and swim and Run profile for now.
- Measures include Weight, HRV and Nutrition charts.
Complements 5e4189f and fixes #3899
2022-08-10 18:11:42 -03:00
Alejandro Martinez
5e4189fa1a Add Run, Swim and combined Map perspectives to Default Analysis layout
Run perspective includes Power analysis, Swim includes HR,
and General defaults for Bike and remaining sport.
Map is an experimental tiled perspective including Map and
Performance charts, intended to create and analize intervals.
2022-08-10 11:39:42 -03:00
Alejandro Martinez
c0ec0aaa28 Train View Perspective Switch on Workout selection
To enable workout preview in the more specific layout,
provided the current perspective allows switching,
to avoid unwanted swithing when using the Workout Editor.
Reorder perspectives in default layout.
2022-08-07 17:05:44 -03:00
Alejandro Martinez
d35f7b22e5 Remove qDebug from previous commit
[skip ci]
2022-08-07 15:09:51 -03:00
Alejandro Martinez
be797ffb31 Train View Perspective Switch - Add Map Workout option
So workouts with GPS data but no video can use LiveMap chart,
without messing with basic slope workouts
Update default layout to include a perspective for each mode
Part of #3899
2022-08-07 14:49:15 -03:00
Alejandro Martinez
f015322040 Change FITmetadata.json git mode from symlink to file
[skip AppVeyor]
Fixes #4254
2022-08-07 11:27:43 -03:00
Alejandro Martinez
09686a2cb7 Update Library Charts for v3.6 using standard colors
Part of #3899
2022-08-06 14:09:40 -03:00
Alejandro Martinez
9e13b73375 Add standard color for Stress Ramp Rate
Part of #3914
2022-08-06 14:08:55 -03:00
Alejandro Martinez
f82dd1b456 Metric Trends Charts - Disable ws and multi models 2022-08-06 11:02:30 -03:00
Alejandro Martinez
394309a7a6 Decode Garmin Real-time Stamina from FIT files
Fixes #4253
2022-08-03 11:06:35 -03:00
Alejandro Martinez
dc470ecf74 FITmetadata.json - Avoid symlinks due to git behavior on Windows
Continuation of c50cd4c
2022-08-03 10:56:32 -03:00
Mark Liversedge
c50cd4c0cc Minor tweaks for FIT metadata code/json
.. since it is a generated file lets symlink FITmetadata.json
   to the source maintained in util/fit to save having to copy it etc.

.. also removed unused variable 'write' that was left behind from
   some unused code during development
2022-08-02 08:11:16 +01:00
Alejandro Martinez
4ed7425d0c Fit import - add new sensor types and devices 2022-08-01 23:01:42 -03:00
Mark Liversedge
1b007014f1 Refresh FITmetadata.json from website
.. we try and download the latest from the website when
   the first FIT file is opened.

   Since importing data is generally not a time critical
   action and we only try for the first file this is more
   appropriate than checking at each launch.

.. the version number is not checked, it is assumed the
   version on the website will always be the very latest.
2022-07-31 15:47:53 +01:00
Alejandro Martinez
76bf1bba21 FitRideFile - Fix compiler errors for MSVC Windows builds
Avoid the clash between implicit default constructors and member variables
Continuation of a5d57cf
2022-07-31 11:19:57 -03:00
Mark Liversedge
a5d57cf3fa FitRideFIle uses FITMetadata.json
.. the file is now baked in to the GC binary and loaded
   the first time a FIT file is parsed.

.. the getManuProd() function has been changed to use the
   loaded metadata to derive product descriptions.

.. we still need to update the code to check the version
   available a www.goldencheetah.org and use it if it is
   newer than the one cached/baked in.
2022-07-31 10:50:36 +01:00
Mark Liversedge
0a0c46b0e2 FITmetadata.json
Added the tooling to the util directory to generate a
JSON file with product and manufacturer metadata for
use by the FITRideFile decoder.

[skip ci]
2022-07-30 19:40:09 +01:00
Alejandro Martinez
8dcd869084 New FIT devices, manufacturer and types from FitSDK 21.8
and forum contributions
2022-07-29 12:19:18 -03:00
Alejandro Martinez
0e22bd8d1a Workout and VideoSync Import - Avoid unnecessary Warnings
When the file is imported from Workout and VideoSync Library
Complements c560f80
2022-07-28 20:14:31 -03:00
Alejandro Martinez
73e2e0709b Fix wrapper code for zlib to recognize directories
encoded as files of size=0 with names ending in "/"
Fixes #4189
2022-07-28 15:48:39 -03:00
Alejandro Martinez
c560f80245 Fix misleading warnings on Workout and VideoSync import
Different warnings for 2 cases:
- When the imported filename already exists in the library
- When the copy fails for other reasons
They were merged with different messages.
2022-07-28 14:13:44 -03:00
Alejandro Martinez
83c145c270 ErgDB Download - add erg2 extension and uncheck All by default
Add erg2 extension as one of admited workout formats to avoid
Scan Workouts removing all referenes to them.
Also uncheck Select All setting by default since currently
there are hundreds of workouts and downloading all of them is unlikely
what the users want to do, besides they are not that easy to remove.
2022-07-28 11:47:35 -03:00
Alejandro Martinez
e738b81c7c DataFilter - Add events function to get current season events
events(date|name|priority|description) returns a vector with the
required field for each event in the current date range span.
For example, to create vertical lines in a Trends User Chart:
sapply(events(date), { annotate(vline, events(name)[i], solid, x); });
2022-07-27 14:54:14 -03:00
Michal Powalko
d282d1f5b2 Add ID for Garmin Edge 1040 Solar 2022-07-27 12:02:27 +02:00
Alejandro Martinez
34b028ae1a Generic Plot Line Annotations - convert units according to axis type (#4250)
Time example for Activities: annotate(vline, "mid", solid, Duration/2);
Date example for Trends: annotate(vline, "mid", solid, Duration/2);
Fixes #4116
2022-07-26 19:21:36 -03:00
Alejandro Martinez
8fdc78b3fe Remove perspectives from stacks on Reset Layout
Fixes #4190
2022-07-25 21:00:51 -03:00
Alejandro Martinez
774704c072 Avoid to mischaracterize OW swims as Pool swims
When GPS data was available before the first distance tick,
includes test file contributed at the forum.
Fixes #4251
Also reverts the TCX part of 1f094f5 since it is incomplete,
and not such a good idea anyway.
2022-07-25 14:28:13 -03:00
Alejandro Martinez
5ef4146971 Escape backslash and quotes from KPK and DATATABLE tiles program
Fixes #4113
[publish binaries]
2022-07-24 12:13:24 -03:00
Mark Liversedge
eee2ee9be2 Fix Memory Leak Data Filter
.. a well known issue with deletion of datafilters that
   was a side-effect of the old metric refresh code and
   threading.

.. now the computation no longer uses QConcurrent::map
   the issue with deletion of the datafilter is removed.

.. have tested with metric refreshes and removal and
   addition of new user metrics.

.. more testing is required to be sure the problem is
   now completely gone.
2022-07-24 08:29:40 +01:00
Mark Liversedge
3b17371687 Fix Memory Leak in RideFile::apendOrUpdate
.. replacing an existing point failed to free memory
   allocated.

Fixes #4248
2022-07-23 15:01:17 +01:00
Mark Liversedge
75800ce49f Fix memory leak in RideFile::append and friends
.. data point allocated twice on heap in appendOrUpdatePoint
   which is always called by RideFile::append

.. this leak has been present since v3.4 (!)

Fixes #4248
2022-07-23 13:17:33 +01:00
Mark Liversedge
2674bf518b Fix SEGV on Import Chart
.. caused by not setting the perspective property when
   importing a chart.

Fixes #4247
2022-07-23 08:59:43 +01:00