From f10f1cbabf8b70f72feff9bc6ab6d0490430cc27 Mon Sep 17 00:00:00 2001 From: Mark Liversedge Date: Fri, 10 Jan 2014 22:02:46 +0000 Subject: [PATCH] Fix Mass Import Memory Exhaustion .. don't signal when adding a ride, which kicks off all manner of updates across the code, instead we let the metric refresh kick in at the end. .. this is great for an initial load and mass import of large numbers of rides, but sucks for a small number of rides when maybe downloading .. we could make the signalling dependent on the number of rides being imported, so small number still updates the CP charts etc. THIS IS A TEMPORARY FIX TO THE MORE SIGNIFICANT PERFORMANCE ISSUE -- BUT WE DO NEED TO CONSIDER THE ISSUE OF CHART UPDATES --- src/RideImportWizard.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/RideImportWizard.cpp b/src/RideImportWizard.cpp index 8bd82beb8..db171270a 100644 --- a/src/RideImportWizard.cpp +++ b/src/RideImportWizard.cpp @@ -825,7 +825,7 @@ RideImportWizard::abortClicked() tableWidget->item(i,5)->setText(tr("File Overwritten")); } else { tableWidget->item(i,5)->setText(tr("File Saved")); - context->athlete->addRide(QFileInfo(fulltarget).fileName(), true); + context->athlete->addRide(QFileInfo(fulltarget).fileName(), false); } } @@ -870,7 +870,7 @@ RideImportWizard::abortClicked() QFile source(filenames[i]); if (source.copy(fulltarget)) { tableWidget->item(i,5)->setText(tr("File Saved")); - context->athlete->addRide(QFileInfo(fulltarget).fileName(), true); // add to tree view + context->athlete->addRide(QFileInfo(fulltarget).fileName(), false); // add to tree view // free immediately otherwise all imported rides are cached // and with large imports this can lead to memory exhaustion // BUT! Some charts/windows will hava snaffled away the ridefile