nmelone/GoldenCheetah
1
0
Fork 0
mirror of https://github.com/GoldenCheetah/GoldenCheetah.git synced 2026-02-14 08:38:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix SEGV on cancel long search

Browse Source 
A timing issue - when cancelling the background scan
it is possible for the next scan to be performed after
the controller has been deleted.

This is an edge condition and pretty rare, but since it
causes a crash pretty high impact.
This commit is contained in:
Mark Liversedge
2012-01-22 09:05:22 +00:00
parent fd88cd4351
commit e59c32a311
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/AddDeviceWizard.cpp
View File

@@ -215,7 +215,9 @@ DeviceScanner::quickScan(bool deep) // scan quickly or if true scan forever, as
// automatically discover a serial port ...
QString error;
foreach (CommPortPtr port, Serial::myListCommPorts(error)) {
if (wizard->controller->discover(port->name()) == true) {
// check if controller still exists. gets deleted when scan cancelled
if (wizard->controller && wizard->controller->discover(port->name()) == true) {
isfound = true;
wizard->portSpec = port->name();
break;