From db0b9885a52dba313bd8fac20b8231c297cef2ee Mon Sep 17 00:00:00 2001 From: Damien Date: Thu, 10 Apr 2014 20:20:48 +0200 Subject: [PATCH] Twitter: api.twitter.com requires SSL/TLS for all connections --- src/Pages.cpp | 8 +++++--- src/TwitterDialog.cpp | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/Pages.cpp b/src/Pages.cpp index f3f20ace9..672aa31b5 100644 --- a/src/Pages.cpp +++ b/src/Pages.cpp @@ -610,7 +610,7 @@ void CredentialsPage::authoriseTwitter() t_key = NULL; t_secret = NULL; - const char *request_token_uri = "http://api.twitter.com/oauth/request_token"; + const char *request_token_uri = "https://api.twitter.com/oauth/request_token"; char *req_url = NULL; char *postarg = NULL; @@ -623,7 +623,7 @@ void CredentialsPage::authoriseTwitter() token = QString(rv[1]); t_key =strdup(&(rv[1][12])); t_secret =strdup(&(rv[2][19])); - url = QString("http://api.twitter.com/oauth/authorize?"); + url = QString("https://api.twitter.com/oauth/authorize?"); url.append(token); QDesktopServices::openUrl(QUrl(url)); if(rv) free(rv); @@ -637,7 +637,7 @@ void CredentialsPage::saveTwitter() char *req_url; char **rv = NULL; char *postarg = NULL; - QString url = QString("http://api.twitter.com/oauth/access_token?a=b&oauth_verifier="); + QString url = QString("https://api.twitter.com/oauth/access_token?a=b&oauth_verifier="); QString strPin = twitterPIN->text(); if(strPin.size() == 0) @@ -685,6 +685,8 @@ void CredentialsPage::authoriseCyclingAnalytics() void CredentialsPage::saveClicked() { + saveTwitter(); + appsettings->setCValue(context->athlete->cyclist, GC_GCURL, gcURL->text()); appsettings->setCValue(context->athlete->cyclist, GC_GCUSER, gcUser->text()); appsettings->setCValue(context->athlete->cyclist, GC_GCPASS, gcPass->text()); diff --git a/src/TwitterDialog.cpp b/src/TwitterDialog.cpp index 089de706a..d0d114be8 100644 --- a/src/TwitterDialog.cpp +++ b/src/TwitterDialog.cpp @@ -120,7 +120,7 @@ TwitterDialog::tweetCurrentRide() // This is for API 1.0 // QString qurl = "http://api.twitter.com/1/statuses/update.json?status="; // This is for API 1.1 - QString qurl = "http://api.twitter.com/1.1/statuses/update.json?status="; + QString qurl = "https://api.twitter.com/1.1/statuses/update.json?status="; QString twitterMsg = getTwitterMessage();