From d953b44c005f279e09a95cac0cb3dcaa42a08e52 Mon Sep 17 00:00:00 2001 From: Mark Liversedge Date: Tue, 31 Aug 2021 21:08:56 +0100 Subject: [PATCH] OverviewItemConfig Legacy Selector ..is only needed for configuring data tables. Fixes #4031 --- src/Charts/OverviewItems.cpp | 27 +++++++++++++++------------ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/src/Charts/OverviewItems.cpp b/src/Charts/OverviewItems.cpp index 81a47567d..ead651414 100644 --- a/src/Charts/OverviewItems.cpp +++ b/src/Charts/OverviewItems.cpp @@ -3461,19 +3461,22 @@ OverviewItemConfig::OverviewItemConfig(ChartSpaceItem *item) : QWidget(NULL), it layout->addRow(tr("Name"), name); } - legacySelector = new QComboBox(this); - legacySelector->addItem("User defined", 0); - legacySelector->addItem("Totals", DATA_TABLE_TOTALS); - legacySelector->addItem("Averages", DATA_TABLE_AVERAGES); - legacySelector->addItem("Maximums", DATA_TABLE_MAXIMUMS); - legacySelector->addItem("Metrics", DATA_TABLE_METRICS); - legacySelector->addItem("Zones", DATA_TABLE_ZONES); - if (item->parent->scope & OverviewScope::ANALYSIS && item->type == OverviewItemType::DATATABLE) { - legacySelector->addItem("Intervals", DATA_TABLE_INTERVALS); - } + if (item->type == OverviewItemType::DATATABLE) { + legacySelector = new QComboBox(this); + legacySelector->addItem("User defined", 0); + legacySelector->addItem("Totals", DATA_TABLE_TOTALS); + legacySelector->addItem("Averages", DATA_TABLE_AVERAGES); + legacySelector->addItem("Maximums", DATA_TABLE_MAXIMUMS); + legacySelector->addItem("Metrics", DATA_TABLE_METRICS); + legacySelector->addItem("Zones", DATA_TABLE_ZONES); + if (item->parent->scope & OverviewScope::ANALYSIS) { + legacySelector->addItem("Intervals", DATA_TABLE_INTERVALS); + } - layout->addRow(tr("Legacy"), legacySelector); - connect(legacySelector, SIGNAL(currentIndexChanged(int)), this, SLOT(setProgram(int))); + layout->addRow(tr("Legacy"), legacySelector); + connect(legacySelector, SIGNAL(currentIndexChanged(int)), this, SLOT(setProgram(int))); + + } // trends view always has a filter if (item->parent->scope & OverviewScope::TRENDS) {