QZip improvements (#4768)

Removed unused constructors
Replaced raw pointer with a unique_ptr to clearly pass ownership.
Fixed a bug where we compared if a signed integer is negative (it never is).
Fixed a case where we take the pointer to a pointer we de-reference!
This commit is contained in:
Magnus Gille
2025-12-27 11:06:45 -08:00
committed by GitHub
parent 2d463c8bc2
commit c4e880622b
5 changed files with 45 additions and 49 deletions

View File

@@ -67,8 +67,8 @@ class ZipReader
{
public:
ZipReader(const QString &fileName, QIODevice::OpenMode mode = QIODevice::ReadOnly );
explicit ZipReader(std::unique_ptr<QIODevice> device);
explicit ZipReader(QIODevice *device);
~ZipReader();
QIODevice* device() const;
@@ -114,8 +114,7 @@ public:
void close();
private:
ZipReaderPrivate *d;
Q_DISABLE_COPY(ZipReader)
std::unique_ptr<ZipReaderPrivate> d;
};
QT_END_NAMESPACE