From b2fb4b40ed0b5b9f0b017d8a4cbec8446945a76d Mon Sep 17 00:00:00 2001 From: Mark Liversedge Date: Sat, 10 Sep 2011 14:18:34 +0100 Subject: [PATCH] Fix possible SEGV in RideSummaryWindow Added logic to trap for NULL RideMetricPtr. Shouldn't occur but trap all the same. --- src/RideSummaryWindow.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/RideSummaryWindow.cpp b/src/RideSummaryWindow.cpp index 1997532e9..ac1d6ae5a 100644 --- a/src/RideSummaryWindow.cpp +++ b/src/RideSummaryWindow.cpp @@ -203,7 +203,9 @@ RideSummaryWindow::htmlSummary() const QHash computed = RideMetric::computeMetrics(mainWindow, ride, mainWindow->zones(), mainWindow->hrZones(), worklist); for(int i = 0; i < worklist.count(); ++i) { if (worklist[i] != "") { - metrics.setForSymbol(worklist[i], computed.value(worklist[i])->value(true)); + RideMetricPtr m = computed.value(worklist[i]); + if (m) metrics.setForSymbol(worklist[i], m->value(true)); + else metrics.setForSymbol(worklist[i], 0.00); } } } else {