From 9ab4de339eb2ad4a2925972f7062c2fbcbaf436f Mon Sep 17 00:00:00 2001 From: Jaime Date: Mon, 11 Feb 2013 15:33:59 +0000 Subject: [PATCH] Code Cleanup: Ride Editor memory leak .. for LTMOutliers, now alloced on stack not heap. --- src/RideEditor.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/RideEditor.cpp b/src/RideEditor.cpp index d30f69bc3..55a397438 100644 --- a/src/RideEditor.cpp +++ b/src/RideEditor.cpp @@ -390,20 +390,20 @@ AnomalyDialog::check() double max = appsettings->value(this, GC_DPFS_MAX, "1500").toDouble(); double variance = appsettings->value(this, GC_DPFS_VARIANCE, "1000").toDouble(); - LTMOutliers *outliers = new LTMOutliers(secs.data(), power.data(), power.count(), 30, false); + LTMOutliers outliers(secs.data(), power.data(), power.count(), 30, false); // run through the ranked list for (int i=0; igetDeviationForRank(i) < variance) break; + if (outliers.getDeviationForRank(i) < variance) break; // ok, so its highly variant but is it over // the max value we are willing to accept? - if (outliers->getYForRank(i) < max) continue; + if (outliers.getYForRank(i) < max) continue; // which one is it - rideEditor->data->anomalies.insert(xsstring(outliers->getIndexForRank(i), RideFile::watts), tr("Data spike candidate")); + rideEditor->data->anomalies.insert(xsstring(outliers.getIndexForRank(i), RideFile::watts), tr("Data spike candidate")); } }