From 90f8560da932f28aa292f7fb2d145e76649aa183 Mon Sep 17 00:00:00 2001 From: Mark Liversedge Date: Sun, 10 Feb 2013 10:59:54 +0000 Subject: [PATCH] Code Cleanup: Model Plot .. used XXX as warnings rather than todo. --- src/ModelPlot.cpp | 12 ++++++------ src/ModelWindow.cpp | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/ModelPlot.cpp b/src/ModelPlot.cpp index 6de944921..095f3a9e5 100644 --- a/src/ModelPlot.cpp +++ b/src/ModelPlot.cpp @@ -275,7 +275,7 @@ ModelDataProvider::describeType(int type, bool longer) }else { return tr("Elapsed Distance (mi)"); } - case MODEL_INTERVAL : return tr("Interval Number"); // XXX implemented differently + case MODEL_INTERVAL : return tr("Interval Number"); case MODEL_LAT : return tr("Latitude (degree x 1000)"); case MODEL_LONG : return tr("Longitude (degree x 1000)"); case MODEL_CPV : return tr("Circumferential Pedal Velocity (cm/s)"); @@ -293,12 +293,12 @@ ModelDataProvider::describeType(int type, bool longer) case MODEL_POWER : return tr("Power"); case MODEL_CADENCE : return tr("Cadence"); case MODEL_HEARTRATE : return tr("Heartrate"); - case MODEL_SPEED : return tr("Speed"); //XXX metric / imperial! - case MODEL_ALT : return tr("Altitude"); // XXX metric / imperial + case MODEL_SPEED : return tr("Speed"); + case MODEL_ALT : return tr("Altitude"); case MODEL_TORQUE : return tr("Pedal Force"); case MODEL_TIME : return tr("Time"); - case MODEL_DISTANCE : return tr("Distance");//XXX metric/imperial - case MODEL_INTERVAL : return tr("Interval"); // XXX implemented differently + case MODEL_DISTANCE : return tr("Distance"); + case MODEL_INTERVAL : return tr("Interval"); case MODEL_LAT : return tr("Latitude"); case MODEL_LONG : return tr("Longitude"); case MODEL_XYTIME : return tr("Time at X/Y"); @@ -430,7 +430,7 @@ ModelDataProvider::ModelDataProvider (BasicModelPlot &plot, ModelSettings *setti plot.intervals_ = SHOW_INTERVALS; if (settings->frame == true) plot.intervals_ |= SHOW_FRAME; - QString lookup = xystring(binx, biny); // XXX SEGV on QString in multiple hashes!!!! XXX + QString lookup = xystring(binx, biny); // filter for interval for(int i=0; iintervals.count(); i++) { diff --git a/src/ModelWindow.cpp b/src/ModelWindow.cpp index d1efcfd99..005d5e654 100644 --- a/src/ModelWindow.cpp +++ b/src/ModelWindow.cpp @@ -243,9 +243,9 @@ ModelWindow::setData(bool adjustPlot) settings.y = ySelector->itemData(ySelector->currentIndex()).toInt(); settings.z = zSelector->itemData(zSelector->currentIndex()).toInt(); settings.color = colorSelector->itemData(colorSelector->currentIndex()).toInt(); - settings.xbin = binWidthSlider->value(); // XXX fixed to single bin width - settings.ybin = binWidthSlider->value(); // XXX due to issues with bar geometry - settings.crop = false; // XXX not implemented + settings.xbin = binWidthSlider->value(); + settings.ybin = binWidthSlider->value(); + settings.crop = false; // not implemented yet settings.zpane = 0; settings.ignore = ignore->isChecked(); settings.gridlines = grid->isChecked();