nmelone/GoldenCheetah
1
0
Fork 0
mirror of https://github.com/GoldenCheetah/GoldenCheetah.git synced 2026-02-13 08:08:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Metric override icon incorrectly displayed in Trends Overview (#4684)

Browse Source
This commit is contained in:
Paul Johnson
2025-08-04 17:41:31 +01:00
committed by GitHub
parent 6e9a1f9306
commit 63e2496fde
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Charts/OverviewItems.cpp
View File

@@ -850,8 +850,10 @@ MetricOverviewItem::configChanged(qint32) {
RideMetricFactory& factory = RideMetricFactory::instance(); RideMetricFactory& factory = RideMetricFactory::instance();
metric = factory.rideMetric(symbol); metric = factory.rideMetric(symbol);
// Only display the override option for metrics that exist. // Only display the override option for metrics that exist, and those related to specific activities.
setShowEdit(metric != nullptr); // It doesn't make sense to overide metrics related to multiple activities, date ranges and/or filters.
setShowEdit((metric != nullptr) && (parent->scope == OverviewScope::ANALYSIS));
units = (metric) ? metric->units(GlobalContext::context()->useMetricUnits) : ""; units = (metric) ? metric->units(GlobalContext::context()->useMetricUnits) : "";
// Update the value and override status // Update the value and override status