From 5ab5bc701002a47c7ccff5163555b54ffc437e99 Mon Sep 17 00:00:00 2001 From: Sean Rhea Date: Sun, 20 Sep 2009 22:18:57 -0700 Subject: [PATCH] move bikescore up in ride summary ...so that the intervals summary is "above the fold". That may be a little on the wide side for small screens, but it's still less wide than the intervals summary, so it's not the worst offender in that regard. --- src/RideItem.cpp | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/RideItem.cpp b/src/RideItem.cpp index e91c807a7..548de1e19 100644 --- a/src/RideItem.cpp +++ b/src/RideItem.cpp @@ -336,16 +336,18 @@ RideItem::htmlSummary() QString noteString = ""; QString stars; QDomNodeList groups = doc.elementsByTagName("metric_group"); + const int columns = 3; for (int groupNum = 0; groupNum < groups.size(); ++groupNum) { QDomElement group = groups.at(groupNum).toElement(); assert(!group.isNull()); QString groupName = group.attribute("name"); QString groupNote = group.attribute("note"); assert(groupName.length() > 0); - if (groupNum % 2 == 0) + if (groupNum % columns == 0) summary += ""; - summary += "
" - ""; + summary += ""; - if ((groupNum % 2 == 1) || (groupNum == groups.size() - 1)) + if ((groupNum % columns == (columns - 1)) + || (groupNum == groups.size() - 1)) summary += "

%1

" + ""; + summary = summary.arg(90 / columns); if (groupNote.length() > 0) { stars += "*"; summary = summary.arg(groupName + stars); @@ -384,7 +386,8 @@ RideItem::htmlSummary() } } summary += "

%2

"; }