nmelone/GoldenCheetah
1
0
Fork 0
mirror of https://github.com/GoldenCheetah/GoldenCheetah.git synced 2026-02-14 08:38:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

RunMetrics - Fix Efficiency Index

Browse Source 
Average Power is based on Time Recording, not Duration,
so the averaging base fixup is changed accordingly.
Aggregation is now based on Time Moving instead on 1,
to account for the relative weight of different runs.
This commit is contained in:
Alejandro Martinez
2024-06-21 12:42:42 -03:00
parent 68e18ae65e
commit 0d78b3e9c8
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Metrics/RunMetrics.cpp
View File

@@ -361,15 +361,15 @@ class EfficiencyIndex : public RideMetric {
double avg_power = deps.value("average_power")->value(true);
double avg_speed = deps.value("average_speed")->value(true);
double workout_time = deps.value("workout_time")->value(true);
double time_recording = deps.value("time_recording")->value(true);
double time_moving = deps.value("time_riding")->value(true);
double ei=0;
if (avg_power > 0.00f && workout_time > 0.00f)
ei = 1000 * avg_speed * time_moving / 60.0 / avg_power / workout_time;
if (avg_power > 0.00f && time_recording > 0.00f)
ei = 1000 * avg_speed * time_moving / 60.0 / avg_power / time_recording;
setValue(ei);
setCount(1);
setCount(time_moving);
}
bool isRelevantForRide(const RideItem *ride) const { return ride->isRun && ride->present.contains("P") && ride->present.contains("S"); }
@@ -384,7 +384,7 @@ static bool addEfficiencyIndex()
QVector<QString> deps;
deps.append("average_power");
deps.append("average_speed");
deps.append("workout_time");
deps.append("time_recording");
deps.append("time_riding");
RideMetricFactory::instance().addMetric(EfficiencyIndex(), &deps);
return true;