nmelone/GoldenCheetah
1
0
Fork 0
mirror of https://github.com/GoldenCheetah/GoldenCheetah.git synced 2026-02-15 08:59:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor MainWindow Part 2 of 5

Browse Source 
Decoupled classes from MainWindow to reference Context
and Athlete (and introduced a couple of new headers).

We no longer pass around a MainWindow pointer to children
but pass a context instead.

There are still a few pieces left in MainWindow that need
to move to a better place;
    * Setting/clearing filter selection
    * Working with Intervals
    * Adding/Deleting Rides
    * Save on Exit

As mentioned previously there are lots of other parts to
this refactor left to do;
    * break MainWindow Gui elements into Toolbar and Views

    * migrate from RideItem and Ridelist to ActivityCollection
      and Activity classes that are not tied into gui elements.

    * introduce Application Context and AthleteCollection
This commit is contained in:
Mark Liversedge
2013-07-10 13:57:30 +01:00
parent cd54ce16c8
commit 05f1d577db
235 changed files with 2196 additions and 1948 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/BingMap.cpp
View File

@@ -21,7 +21,8 @@
#include "RideItem.h"
#include "RideFile.h"
#include "IntervalItem.h"
#include "MainWindow.h"
#include "Context.h"
#include "Athlete.h"
#include "Zones.h"
#include "Settings.h"
#include "Colors.h"
@@ -30,7 +31,7 @@
#include <QDebug>
BingMap::BingMap(MainWindow *mw) : GcWindow(mw), main(mw), range(-1), current(NULL)
BingMap::BingMap(Context *context) : GcWindow(context), context(context), range(-1), current(NULL)
{
setInstanceName("Google Map");
setControls(NULL);
@@ -40,7 +41,7 @@ BingMap::BingMap(MainWindow *mw) : GcWindow(mw), main(mw), range(-1), current(NU
layout->setContentsMargins(2,0,2,2);
setLayout(layout);
parent = mw;
//XXX ???? parent = context->mainWindow;
view = new QWebView();
view->setContentsMargins(0,0,0,0);
view->page()->view()->setContentsMargins(0,0,0,0);
@@ -48,13 +49,13 @@ BingMap::BingMap(MainWindow *mw) : GcWindow(mw), main(mw), range(-1), current(NU
view->setAcceptDrops(false);
layout->addWidget(view);
webBridge = new BWebBridge(mw, this);
webBridge = new BWebBridge(context, this);
connect(this, SIGNAL(rideItemChanged(RideItem*)), this, SLOT(rideSelected()));
connect(view->page()->mainFrame(), SIGNAL(javaScriptWindowObjectCleared()), this, SLOT(updateFrame()));
connect(mw, SIGNAL(intervalsChanged()), webBridge, SLOT(intervalsChanged()));
connect(mw, SIGNAL(intervalSelected()), webBridge, SLOT(intervalsChanged()));
connect(mw, SIGNAL(intervalZoom(IntervalItem*)), this, SLOT(zoomInterval(IntervalItem*)));
connect(context->mainWindow, SIGNAL(intervalsChanged()), webBridge, SLOT(intervalsChanged()));
connect(context->mainWindow, SIGNAL(intervalSelected()), webBridge, SLOT(intervalsChanged()));
connect(context->mainWindow, SIGNAL(intervalZoom(IntervalItem*)), this, SLOT(zoomInterval(IntervalItem*)));
first = true;
}
@@ -255,7 +256,7 @@ void BingMap::createHtml()
QColor BingMap::GetColor(int watts)
{
if (range < 0) return Qt::red;
else return zoneColor(main->athlete->zones()->whichZone(range, watts), 7);
else return zoneColor(context->athlete->zones()->whichZone(range, watts), 7);
}
// create the ride line
@@ -429,7 +430,7 @@ BingMap::createMarkers()
//
// INTERVAL MARKERS
//
if (main->allIntervalItems() == NULL) return; // none to do, we are all done then
if (context->mainWindow->allIntervalItems() == NULL) return; // none to do, we are all done then
int interval=0;
foreach (const RideFileInterval x, myRideItem->ride()->intervals()) {
@@ -508,11 +509,11 @@ BWebBridge::intervalCount()
highlighted = 0;
RideItem *rideItem = gm->property("ride").value<RideItem*>();
if (mainWindow->allIntervalItems() == NULL ||
if (context->mainWindow->allIntervalItems() == NULL ||
rideItem == NULL || rideItem->ride() == NULL) return 0; // not inited yet!
for (int i=0; i<mainWindow->allIntervalItems()->childCount(); i++) {
IntervalItem *current = dynamic_cast<IntervalItem *>(mainWindow->allIntervalItems()->child(i));
for (int i=0; i<context->mainWindow->allIntervalItems()->childCount(); i++) {
IntervalItem *current = dynamic_cast<IntervalItem *>(context->mainWindow->allIntervalItems()->child(i));
if (current != NULL) {
if (current->isSelected() == true) {
++highlighted;
@@ -530,14 +531,14 @@ BWebBridge::getLatLons(int i)
int highlighted=0;
RideItem *rideItem = gm->property("ride").value<RideItem*>();
if (mainWindow->allIntervalItems() == NULL ||
if (context->mainWindow->allIntervalItems() == NULL ||
rideItem ==NULL || rideItem->ride() == NULL) return latlons; // not inited yet!
if (i) {
// get for specific interval
for (int j=0; j<mainWindow->allIntervalItems()->childCount(); j++) {
IntervalItem *current = dynamic_cast<IntervalItem *>(mainWindow->allIntervalItems()->child(j));
for (int j=0; j<context->mainWindow->allIntervalItems()->childCount(); j++) {
IntervalItem *current = dynamic_cast<IntervalItem *>(context->mainWindow->allIntervalItems()->child(j));
if (current != NULL) {
if (current->isSelected() == true) {
++highlighted;
@@ -590,6 +591,6 @@ BWebBridge::drawOverlays()
void
BWebBridge::toggleInterval(int x)
{
IntervalItem *current = dynamic_cast<IntervalItem *>(mainWindow->allIntervalItems()->child(x));
IntervalItem *current = dynamic_cast<IntervalItem *>(context->mainWindow->allIntervalItems()->child(x));
if (current) current->setSelected(!current->isSelected());
}